Remove unnecessary requires_usage and deprecated_allow_duplicates #29642
Merged
honeybadgerdontcare merged 2 commits intoampproject:masterfrom Aug 4, 2020
Merged
Conversation
|
Hey @ampproject/wg-caching! These files were changed: |
dreamofabear
approved these changes
Aug 4, 2020
twifkak
added a commit
to twifkak/amphtml
that referenced
this pull request
Aug 5, 2020
Merged
twifkak
added a commit
that referenced
this pull request
Aug 5, 2020
* cl/323700659 Revision bump for #29329 * cl/323797874 Revision bump for #29542 * cl/323858009 Revision bump for #29409 * cl/323889989 n/a * cl/324641097 Implements document level byte count limitation. * cl/324911894 Remove AMP Actions from Validator * cl/324915915 Revision bump for #29642 Co-authored-by: Greg Grothaus <greggrothaus@google.com> Co-authored-by: Amaltas Bohra <amaltas@google.com> Co-authored-by: honeybadgerdontcare <sedano@google.com>
Member
|
This broke many AMP email senders as many were actually relying on this grandfathered behavior. In the future, please tag @ampproject/wg-amp4email before making changes to AMP for Email spec so we can take a look before the change happens, thanks. |
Member
|
Sorry, I see that the WG is mentioned in #25249, but unfortunately we (Gmail) weren't included in that group back then... Should be good to go going forward. |
ed-bird
pushed a commit
to ed-bird/amphtml
that referenced
this pull request
Dec 10, 2020
…pproject#29642) * Remove unnecessary requires_usage and deprecated_allow_duplicates for AMP4EMAIL * Update test .out file
ed-bird
pushed a commit
to ed-bird/amphtml
that referenced
this pull request
Dec 10, 2020
* cl/323700659 Revision bump for ampproject#29329 * cl/323797874 Revision bump for ampproject#29542 * cl/323858009 Revision bump for ampproject#29409 * cl/323889989 n/a * cl/324641097 Implements document level byte count limitation. * cl/324911894 Remove AMP Actions from Validator * cl/324915915 Revision bump for ampproject#29642 Co-authored-by: Greg Grothaus <greggrothaus@google.com> Co-authored-by: Amaltas Bohra <amaltas@google.com> Co-authored-by: honeybadgerdontcare <sedano@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #24854 the validation for the AMP Email format script tags was separated from other AMP formats. This allowed for the removing support of version: latest and explicitly required a numerical version.
As a result of this separation from other HTML formats, it is not necessary to include requires_usage: EXEMPT or deprecated_allow_duplicates: true as part of the AMP Email format. Those were included to support the AMP format.
Fix #25249