Skip to content

🐛 Allow select and use as descendants of mega-menu and nested-menu#29409

Merged
wassgha merged 1 commit intoampproject:masterfrom
wassgha:allowlist/sidebar
Jul 28, 2020
Merged

🐛 Allow select and use as descendants of mega-menu and nested-menu#29409
wassgha merged 1 commit intoampproject:masterfrom
wassgha:allowlist/sidebar

Conversation

@wassgha
Copy link
Copy Markdown
Contributor

@wassgha wassgha commented Jul 21, 2020

Closes #29300

Copy link
Copy Markdown
Contributor

@honeybadgerdontcare honeybadgerdontcare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for validation changes

@Gregable
Copy link
Copy Markdown
Member

Oops, didn't see that @honeybadgerdontcare had already replied.

@wassgha wassgha merged commit 48b6414 into ampproject:master Jul 28, 2020
twifkak pushed a commit to twifkak/amphtml that referenced this pull request Aug 5, 2020
@twifkak twifkak mentioned this pull request Aug 5, 2020
twifkak added a commit that referenced this pull request Aug 5, 2020
* cl/323700659 Revision bump for #29329
* cl/323797874 Revision bump for #29542
* cl/323858009 Revision bump for #29409
* cl/323889989 n/a
* cl/324641097 Implements document level byte count limitation.
* cl/324911894 Remove AMP Actions from Validator
* cl/324915915 Revision bump for #29642

Co-authored-by: Greg Grothaus <greggrothaus@google.com>
Co-authored-by: Amaltas Bohra <amaltas@google.com>
Co-authored-by: honeybadgerdontcare <sedano@google.com>
ed-bird pushed a commit to ed-bird/amphtml that referenced this pull request Dec 10, 2020
ed-bird pushed a commit to ed-bird/amphtml that referenced this pull request Dec 10, 2020
* cl/323700659 Revision bump for ampproject#29329
* cl/323797874 Revision bump for ampproject#29542
* cl/323858009 Revision bump for ampproject#29409
* cl/323889989 n/a
* cl/324641097 Implements document level byte count limitation.
* cl/324911894 Remove AMP Actions from Validator
* cl/324915915 Revision bump for ampproject#29642

Co-authored-by: Greg Grothaus <greggrothaus@google.com>
Co-authored-by: Amaltas Bohra <amaltas@google.com>
Co-authored-by: honeybadgerdontcare <sedano@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow use and select as a descendant of amp-nested-menu

5 participants