🐛 Allow select and use as descendants of mega-menu and nested-menu#29409
Merged
wassgha merged 1 commit intoampproject:masterfrom Jul 28, 2020
Merged
🐛 Allow select and use as descendants of mega-menu and nested-menu#29409wassgha merged 1 commit intoampproject:masterfrom
select and use as descendants of mega-menu and nested-menu#29409wassgha merged 1 commit intoampproject:masterfrom
Conversation
honeybadgerdontcare
approved these changes
Jul 21, 2020
Contributor
honeybadgerdontcare
left a comment
There was a problem hiding this comment.
LGTM for validation changes
Gregable
approved these changes
Jul 21, 2020
Member
|
Oops, didn't see that @honeybadgerdontcare had already replied. |
caroqliu
approved these changes
Jul 22, 2020
twifkak
pushed a commit
to twifkak/amphtml
that referenced
this pull request
Aug 5, 2020
Merged
twifkak
added a commit
that referenced
this pull request
Aug 5, 2020
* cl/323700659 Revision bump for #29329 * cl/323797874 Revision bump for #29542 * cl/323858009 Revision bump for #29409 * cl/323889989 n/a * cl/324641097 Implements document level byte count limitation. * cl/324911894 Remove AMP Actions from Validator * cl/324915915 Revision bump for #29642 Co-authored-by: Greg Grothaus <greggrothaus@google.com> Co-authored-by: Amaltas Bohra <amaltas@google.com> Co-authored-by: honeybadgerdontcare <sedano@google.com>
ed-bird
pushed a commit
to ed-bird/amphtml
that referenced
this pull request
Dec 10, 2020
ed-bird
pushed a commit
to ed-bird/amphtml
that referenced
this pull request
Dec 10, 2020
* cl/323700659 Revision bump for ampproject#29329 * cl/323797874 Revision bump for ampproject#29542 * cl/323858009 Revision bump for ampproject#29409 * cl/323889989 n/a * cl/324641097 Implements document level byte count limitation. * cl/324911894 Remove AMP Actions from Validator * cl/324915915 Revision bump for ampproject#29642 Co-authored-by: Greg Grothaus <greggrothaus@google.com> Co-authored-by: Amaltas Bohra <amaltas@google.com> Co-authored-by: honeybadgerdontcare <sedano@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #29300