Fix more arrow functions that are passed in as "constructors"#26795
Merged
erwinmombay merged 2 commits intoampproject:masterfrom Feb 14, 2020
Merged
Fix more arrow functions that are passed in as "constructors"#26795erwinmombay merged 2 commits intoampproject:masterfrom
erwinmombay merged 2 commits intoampproject:masterfrom
Conversation
|
Hey @jridgewell, these files were changed:
|
kristoferbaxter
approved these changes
Feb 14, 2020
|
This pull request introduces 1 alert when merging 9fe89ce into 882bc62 - view on LGTM.com new alerts:
|
d0ea3c9 to
1728bdd
Compare
…function expressions
1728bdd to
4a691fe
Compare
Member
Author
|
per @rsimha i've skipped over a bunch of tests that seem to be only failing in isolation, they already fail on master if you isolate then in a unit test run. will try and fix the issue in a subsequent PR |
dvoytenko
approved these changes
Feb 14, 2020
erwinmombay
added a commit
that referenced
this pull request
Feb 14, 2020
* change all arrow functions registered as factory functions to normal function expressions * skip tests that fail in isolation. these tests already fail on master
robinvanopstal
added a commit
to jungvonmatt/amphtml
that referenced
this pull request
Feb 17, 2020
* master: (181 commits) 🏗 Ensure valid flag usage for `gulp` tasks (ampproject#26814) build-system: Fix autocomplete error response (ampproject#26824) application/json is ab allowed type for <script> (ampproject#26815) 🚮 Removing amp-consent-v2 experiment logic (ampproject#26162) Fix more arrow functions that are passed in as "constructors" (ampproject#26795) Variable substitution tester (ampproject#26695) Turn on restrict fullscreen canary (ampproject#26766) Mock variableService getMacros (ampproject#26300) Sync from Google (ampproject#26805) Sync from Google (ampproject#26803) Move video_state macro (ampproject#26212) 🚀 Move ads variables to amp-analytics (ampproject#25113) Sync from Google (ampproject#26800) Sync from Google (ampproject#26798) Sync from Google (ampproject#26792) Another set of example.com change (ampproject#26753) Add PWA multidoc loader to examples (ampproject#26680) 🐛Check for window null before creating tracking pixel (ampproject#26749) trying to update Sauce timeouts (ampproject#26737) 🐛Fixes swipe to dismiss badly ordered swipes on `amp-lightbox-gallery` (ampproject#26788) ... # Conflicts: # extensions/amp-accordion/amp-accordion.md # extensions/amp-bind/amp-bind.md
erwinmombay
added a commit
that referenced
this pull request
Feb 18, 2020
* change all arrow functions registered as factory functions to normal function expressions * skip tests that fail in isolation. these tests already fail on master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
arrow functions should not be passed in as constructors as eventually they will be
new'd up and cause an erroralso filed against closure compiler team google/closure-compiler#3550