🚀 Move ads variables to amp-analytics#25113
Merged
micajuine-ho merged 9 commits intoampproject:masterfrom Feb 14, 2020
Merged
Conversation
zhouyx
reviewed
Oct 18, 2019
zhouyx
reviewed
Oct 22, 2019
Contributor
zhouyx
left a comment
There was a problem hiding this comment.
Looks great. One last request. Can we please add the three variables to our integration test at test-amp-analytics.js Thanks!
7 tasks
57dd441 to
48a87b2
Compare
48a87b2 to
ddf34a7
Compare
zhouyx
reviewed
Feb 11, 2020
| }); | ||
|
|
||
| it('should send request', () => { | ||
| it.only('should send request', () => { |
| "loadend": "\${navTiming(loadEventEnd)}", | ||
| "default": "\$DEFAULT( , test)", | ||
| "cookie": "\${cookie(test-cookie)}" | ||
| "cookie": "\${cookie(test-cookie)}", |
Contributor
There was a problem hiding this comment.
What's the file that we need to add a <p>Hello World</p> to get FIRST_CONTENTFUL_PAINT value? Asking because I think this is the one.
52b2820 to
b11689b
Compare
b11689b to
1576daf
Compare
zhouyx
approved these changes
Feb 14, 2020
| <p> | ||
| Integer in felis at lacus mattis facilisis. Curabitur tincidunt, felis porttitor mollis finibus, tortor elit elementum dolor, vel vulputate lorem dui id ante. Vivamus in velit at lectus blandit gravida vitae quis arcu. Nam et magna magna. Fusce condimentum diam lacus, ac ullamcorper purus malesuada eu. Mauris ullamcorper elit et venenatis faucibus. Nullam lobortis molestie purus quis pellentesque. Sed at libero id nisi rhoncus tincidunt. Praesent vestibulum vehicula tristique. Etiam rutrum, nunc id porta interdum, nulla nisi molestie leo, at fermentum justo dolor at lorem. Duis in egestas sapien. | ||
| </p> | ||
| <amp-video |
Contributor
There was a problem hiding this comment.
nit: since you removed amp-video, you may also want to remove amp-video-0.1.js
robinvanopstal
added a commit
to jungvonmatt/amphtml
that referenced
this pull request
Feb 17, 2020
* master: (181 commits) 🏗 Ensure valid flag usage for `gulp` tasks (ampproject#26814) build-system: Fix autocomplete error response (ampproject#26824) application/json is ab allowed type for <script> (ampproject#26815) 🚮 Removing amp-consent-v2 experiment logic (ampproject#26162) Fix more arrow functions that are passed in as "constructors" (ampproject#26795) Variable substitution tester (ampproject#26695) Turn on restrict fullscreen canary (ampproject#26766) Mock variableService getMacros (ampproject#26300) Sync from Google (ampproject#26805) Sync from Google (ampproject#26803) Move video_state macro (ampproject#26212) 🚀 Move ads variables to amp-analytics (ampproject#25113) Sync from Google (ampproject#26800) Sync from Google (ampproject#26798) Sync from Google (ampproject#26792) Another set of example.com change (ampproject#26753) Add PWA multidoc loader to examples (ampproject#26680) 🐛Check for window null before creating tracking pixel (ampproject#26749) trying to update Sauce timeouts (ampproject#26737) 🐛Fixes swipe to dismiss badly ordered swipes on `amp-lightbox-gallery` (ampproject#26788) ... # Conflicts: # extensions/amp-accordion/amp-accordion.md # extensions/amp-bind/amp-bind.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Project Tracker: #26091
Move FIRST_CONTENTFUL_PAINT, FIRST_VIEWPORT_READY, MAKE_BODY_VISIBLE macros and their tests