Move video_state macro#26212
Merged
micajuine-ho merged 6 commits intoampproject:masterfrom Feb 14, 2020
Merged
Conversation
7 tasks
zhouyx
reviewed
Jan 6, 2020
alanorozco
approved these changes
Feb 12, 2020
4b8b5ec to
539f57f
Compare
alanorozco
reviewed
Feb 12, 2020
alanorozco
approved these changes
Feb 12, 2020
alanorozco
reviewed
Feb 12, 2020
3c05e69 to
83bd4fb
Compare
83bd4fb to
cba3228
Compare
zhouyx
approved these changes
Feb 14, 2020
robinvanopstal
added a commit
to jungvonmatt/amphtml
that referenced
this pull request
Feb 17, 2020
* master: (181 commits) 🏗 Ensure valid flag usage for `gulp` tasks (ampproject#26814) build-system: Fix autocomplete error response (ampproject#26824) application/json is ab allowed type for <script> (ampproject#26815) 🚮 Removing amp-consent-v2 experiment logic (ampproject#26162) Fix more arrow functions that are passed in as "constructors" (ampproject#26795) Variable substitution tester (ampproject#26695) Turn on restrict fullscreen canary (ampproject#26766) Mock variableService getMacros (ampproject#26300) Sync from Google (ampproject#26805) Sync from Google (ampproject#26803) Move video_state macro (ampproject#26212) 🚀 Move ads variables to amp-analytics (ampproject#25113) Sync from Google (ampproject#26800) Sync from Google (ampproject#26798) Sync from Google (ampproject#26792) Another set of example.com change (ampproject#26753) Add PWA multidoc loader to examples (ampproject#26680) 🐛Check for window null before creating tracking pixel (ampproject#26749) trying to update Sauce timeouts (ampproject#26737) 🐛Fixes swipe to dismiss badly ordered swipes on `amp-lightbox-gallery` (ampproject#26788) ... # Conflicts: # extensions/amp-accordion/amp-accordion.md # extensions/amp-bind/amp-bind.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Project Tracker: #26091
Moving VIDEO_STATE macro to amp-analyticsSince VIDEO_STATE macro is referenced by ID, we can't move it from url-replacements. However we can still decrease v0 size by moving the implementation of the macro to
video-manager-impl.This will also improve the cohesiveness of the video-manager analytics.
Behavior is unchanged (can still use the VIDEO_STATE macro as a part of the url substitution and also in amp-analytics vars).