amp-action: Support whitelist lookup in AmpDocShadow#26684
Merged
mdmower merged 2 commits intoampproject:masterfrom Feb 22, 2020
Merged
amp-action: Support whitelist lookup in AmpDocShadow#26684mdmower merged 2 commits intoampproject:masterfrom
mdmower merged 2 commits intoampproject:masterfrom
Conversation
New getMetaByName method supports retrieving meta content values in shadow docs as well.
33 tasks
Contributor
Author
Member
|
And assume that the head will always be there? Makes sense to me |
It is safe to assume that either document.head is available if AmpDocSingle/AmpDocFie, or that AmpDoc.meta_ is non-null if AmpDocShadow.
samouri
reviewed
Feb 21, 2020
| const root = this.ampdoc.getRootNode(); | ||
| if (!root.head && !(root instanceof ShadowRoot)) { | ||
| return null; | ||
| } |
Member
There was a problem hiding this comment.
Awesome that we no longer need to ship this code ⭐️
robinvanopstal
added a commit
to jungvonmatt/amphtml
that referenced
this pull request
Feb 24, 2020
* master: (41 commits) custom-element: Minor test improvements (ampproject#26923) amp-pixel: Minor test improvements (ampproject#26918) viewer: Minor test improvements (ampproject#26906) dom: Minor test improvements (ampproject#26913) amp-action: Support whitelist lookup in AmpDocShadow (ampproject#26684) ✨ Update amp-access-scroll (ampproject#26810) 🚀 Remove doc css and base css from ESM build (ampproject#26889) 📖 [amp-story-player] Initial docs (ampproject#26606) Amp consent restrict fullscreen prod flag (ampproject#26909) 📖 Clarify SXG duration minimum (ampproject#26890) Improve test vendor requests macros (ampproject#26828) 🚀 Move scroll left and top macros out of url-replacement-impl (ampproject#25594) Update consent string maximum size to 200 bytes (ampproject#26741) ✨[amp-story-player] Adds tap-to-next/previous story (ampproject#26865) update owners file with correct syntax (ampproject#26899) amp-sticky-ad: Fix unit test (ampproject#26855) Add performance metrics to README (ampproject#26891) 🐛 Bug fix: check links test (ampproject#26739) ✨Idealmedia uniq ad (ampproject#25838) 📦 Update dependency jsdom to v16.2.0 (ampproject#26591) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New
getMetaByNamemethod supports retrieving meta content values inshadow docs as well.