🚀 Move scroll left and top macros out of url-replacement-impl#25594
Merged
micajuine-ho merged 24 commits intoampproject:masterfrom Feb 21, 2020
Merged
🚀 Move scroll left and top macros out of url-replacement-impl#25594micajuine-ho merged 24 commits intoampproject:masterfrom
micajuine-ho merged 24 commits intoampproject:masterfrom
Conversation
added 22 commits
November 1, 2019 10:55
7 tasks
zhouyx
reviewed
Jan 3, 2020
Contributor
zhouyx
left a comment
There was a problem hiding this comment.
We should be able to remove the two variables from the A4A allowed list.
Not blocking right now, but any good idea on applying allowed list to variables registered to amp-analytics?
Contributor
Author
|
Not sure, lets discuss offline when I get back, because I think this issue has cropped up before with some of the other PRs |
707993e to
732bfec
Compare
ae13b97 to
c6050d8
Compare
Contributor
Author
|
/cc @jridgewell for |
jridgewell
approved these changes
Feb 21, 2020
zhouyx
approved these changes
Feb 21, 2020
robinvanopstal
added a commit
to jungvonmatt/amphtml
that referenced
this pull request
Feb 24, 2020
* master: (41 commits) custom-element: Minor test improvements (ampproject#26923) amp-pixel: Minor test improvements (ampproject#26918) viewer: Minor test improvements (ampproject#26906) dom: Minor test improvements (ampproject#26913) amp-action: Support whitelist lookup in AmpDocShadow (ampproject#26684) ✨ Update amp-access-scroll (ampproject#26810) 🚀 Remove doc css and base css from ESM build (ampproject#26889) 📖 [amp-story-player] Initial docs (ampproject#26606) Amp consent restrict fullscreen prod flag (ampproject#26909) 📖 Clarify SXG duration minimum (ampproject#26890) Improve test vendor requests macros (ampproject#26828) 🚀 Move scroll left and top macros out of url-replacement-impl (ampproject#25594) Update consent string maximum size to 200 bytes (ampproject#26741) ✨[amp-story-player] Adds tap-to-next/previous story (ampproject#26865) update owners file with correct syntax (ampproject#26899) amp-sticky-ad: Fix unit test (ampproject#26855) Add performance metrics to README (ampproject#26891) 🐛 Bug fix: check links test (ampproject#26739) ✨Idealmedia uniq ad (ampproject#25838) 📦 Update dependency jsdom to v16.2.0 (ampproject#26591) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Project Tracker: #26091
Moving SCROLL_LEFT and SCROLL_TOP macros to amp-analytics
Also fixed existing viewport test.