ampdoc: Relax usage requirements of getMetaByName#26729
Closed
mdmower wants to merge 1 commit intoampproject:masterfrom
Closed
ampdoc: Relax usage requirements of getMetaByName#26729mdmower wants to merge 1 commit intoampproject:masterfrom
mdmower wants to merge 1 commit intoampproject:masterfrom
Conversation
If <head> doesn't exist, don't throw, just return null.
Contributor
Author
|
I'm not actually sure I really want this, but it does reduce the requirements on unit tests. |
dreamofabear
approved these changes
Feb 11, 2020
| */ | ||
| getMetaByName(name) { | ||
| if (!name) { | ||
| if (!name || !this.win.document || !this.win.document.head) { |
Member
There was a problem hiding this comment.
On top of that, how could document.head be null/undefined? I thought even an html document without a <head> tag will still be given an empty one.
Contributor
Author
There was a problem hiding this comment.
In practice, this is only for unit tests. See for example
amphtml/test/unit/test-url-replacements.js
Line 156 in 3d4ed62
document object is defined by hand. I'll defer to you two on whether this change should be merged; I'm impartial.
Contributor
Author
|
Choosing to abandon. Updated unit tests in #26687 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
<head>doesn't exist, don't throw, just returnnull.