♻️ Refactor: Rename strip-prefix to xssi-prefix#25946
♻️ Refactor: Rename strip-prefix to xssi-prefix#25946lannka merged 1 commit intoampproject:masterfrom
Conversation
|
Hey @ampproject/wg-caching, these files were changed:
|
|
@lannka have these been verified to not be in use? otherwise we need an i2d. |
|
@samouri correct me. seems like it's a new feature that is not launched / announced yet? |
|
Poll! |
|
The reason I prefer |
|
To back up my argument, I give a real world analogy If a frying pan is configurable, this will be a more readable config to regular users: instead of |
|
@lannka: I tend to agree with you, as long as |
|
Yeah, lets do it this way. @jridgewell / @lannka: if you have the chance can you submit this? I still don't have merge access. |
269315b to
46865d8
Compare
|
I think either name is fine, but I actually read |
|
@choumx my bad try :-( |
|
It might be more like a frying pan that was specifically meant for eggs, but could technically cook anything. Would you want your frying pan to have the function |
* cl/283618549 Revision bump for #25847 * cl/283654708 mandatory_parent can use spec_name in addition to tag_name * cl/283852039 Introduce a invalid doctype error for amp validation. * cl/283882898 n/a * cl/283993894 Revision bump for #25197 * cl/284115876 Revision bump for #25870 * cl/284258503 Revision bump for #25889 * cl/284856390 Revision bump for #25946
* cl/283618549 Revision bump for ampproject#25847 * cl/283654708 mandatory_parent can use spec_name in addition to tag_name * cl/283852039 Introduce a invalid doctype error for amp validation. * cl/283882898 n/a * cl/283993894 Revision bump for ampproject#25197 * cl/284115876 Revision bump for ampproject#25870 * cl/284258503 Revision bump for ampproject#25889 * cl/284856390 Revision bump for ampproject#25946
summary
Rename the
strip-prefixattribute to the more specificxssi-prefixas suggested by @lannka.