Disabling amp-gfycat support within amp-story-grid-layer.#25847
Merged
gmajoulet merged 1 commit intoampproject:masterfrom Dec 3, 2019
Merged
Disabling amp-gfycat support within amp-story-grid-layer.#25847gmajoulet merged 1 commit intoampproject:masterfrom
gmajoulet merged 1 commit intoampproject:masterfrom
Conversation
|
Hey @ampproject/wg-caching, these files were changed:
|
newmuis
approved these changes
Dec 3, 2019
amaltas
added a commit
that referenced
this pull request
Dec 11, 2019
* cl/283618549 Revision bump for #25847 * cl/283654708 mandatory_parent can use spec_name in addition to tag_name * cl/283852039 Introduce a invalid doctype error for amp validation. * cl/283882898 n/a * cl/283993894 Revision bump for #25197 * cl/284115876 Revision bump for #25870 * cl/284258503 Revision bump for #25889 * cl/284856390 Revision bump for #25946
micajuine-ho
pushed a commit
to micajuine-ho/amphtml
that referenced
this pull request
Dec 27, 2019
micajuine-ho
pushed a commit
to micajuine-ho/amphtml
that referenced
this pull request
Dec 27, 2019
* cl/283618549 Revision bump for ampproject#25847 * cl/283654708 mandatory_parent can use spec_name in addition to tag_name * cl/283852039 Introduce a invalid doctype error for amp validation. * cl/283882898 n/a * cl/283993894 Revision bump for ampproject#25197 * cl/284115876 Revision bump for ampproject#25870 * cl/284258503 Revision bump for ampproject#25889 * cl/284856390 Revision bump for ampproject#25946
This was referenced Apr 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
amp-gfycatwithin anamp-story-grid-layerwas valid AMP, but breaks the UX (cf #25431). Only one story document uses it as of today.Supporting this component would mean adding support for all VideoInterface components: the
<video>element being within a 3p iframe, this doesn't work with the media pool. We'd need to do extra work to manipulate VideoInterface elements on top of<video>elements.Fixes #25431