✨Allow amp-selector in AMP4ADS#25889
Merged
honeybadgerdontcare merged 8 commits intoampproject:masterfrom Dec 6, 2019
Merged
Conversation
|
Hey @ampproject/wg-caching, these files were changed:
|
honeybadgerdontcare
approved these changes
Dec 5, 2019
Contributor
honeybadgerdontcare
left a comment
There was a problem hiding this comment.
Validation looks good.
amaltas
added a commit
that referenced
this pull request
Dec 11, 2019
* cl/283618549 Revision bump for #25847 * cl/283654708 mandatory_parent can use spec_name in addition to tag_name * cl/283852039 Introduce a invalid doctype error for amp validation. * cl/283882898 n/a * cl/283993894 Revision bump for #25197 * cl/284115876 Revision bump for #25870 * cl/284258503 Revision bump for #25889 * cl/284856390 Revision bump for #25946
micajuine-ho
pushed a commit
to micajuine-ho/amphtml
that referenced
this pull request
Dec 27, 2019
* Allow amp-selector in AMP4ADS * add license in test; also updates the list in extensions.html * update approvedAmp4AdsExtensions in test to include amp-selector * fix a bad local change * update year in license
micajuine-ho
pushed a commit
to micajuine-ho/amphtml
that referenced
this pull request
Dec 27, 2019
* cl/283618549 Revision bump for ampproject#25847 * cl/283654708 mandatory_parent can use spec_name in addition to tag_name * cl/283852039 Introduce a invalid doctype error for amp validation. * cl/283882898 n/a * cl/283993894 Revision bump for ampproject#25197 * cl/284115876 Revision bump for ampproject#25870 * cl/284258503 Revision bump for ampproject#25889 * cl/284856390 Revision bump for ampproject#25946
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #25773: updates validator spec and tests to allow amp-selector in AMP4ADS.