Fixes half pixel borders on story desktop.#24050
Merged
gmajoulet merged 1 commit intoampproject:masterfrom Aug 20, 2019
Merged
Conversation
newmuis
reviewed
Aug 20, 2019
Contributor
newmuis
left a comment
There was a problem hiding this comment.
Not 100% sure but won't this cause the browser to put these into new layers? So theoretically there will be some performance hit?
Not sure if they still have it, but Firefox used to have a 3d view to visualize layers in their developer tools; maybe we can check that?
Contributor
Author
|
They were already in new layers because of the |
Contributor
Author
|
Sorry, there's no
|
newmuis
approved these changes
Aug 20, 2019
Contributor
newmuis
left a comment
There was a problem hiding this comment.
Ah, was just looking at the diff and didn't see anything on Z. Should have known that there were a million more styles 😂
Enriqe
approved these changes
Aug 20, 2019
westonruter
added a commit
to westonruter/amphtml
that referenced
this pull request
Aug 20, 2019
* 'master' of github.com:ampproject/amphtml: (32 commits) ✨ Make tweet id a bindable attribute (ampproject#23953) 🏗 Update Local AMP extension to allow custom base URLs (ampproject#24029) 🏗 Improve serving from non-localhost host (ampproject#24066) Preventing half pixels. (ampproject#24050) Update callout-vendors.js (ampproject#23218) 🏗 Fixes to `check-package-manager.js` (ampproject#24060) Rename AMP_MODE to __AMP_MODE. (ampproject#24052) Story media performance metrics. (ampproject#23962) Updating Story amp-sidebar width documentation. (ampproject#23894) Fixes race condition in amp-video-iframe (ampproject#24033) Rename ampExtendedElements to __AMP_EXTENDED_ELEMENTS (ampproject#24056) 🏗🚮 Enable property inlining (ampproject#24053) ✨amp-ads: Added optional params for Directadvert network (ampproject#23724) <amp-experiment> style mutation fix and improvment (ampproject#23669) 🐛 Allow http protocol for noscript > img fallbacks for parity with amp-img (ampproject#21686) 🏗 Refactor transform-log-asserts (ampproject#24028) Automatically preconnect to source origins on page loads. (ampproject#24045) Support visibility API in the ampdoc (ampproject#23799) Amphtml visual tests should use relative path against root (ampproject#24042) FIX: check all fields' dirtiness on AMP form init (ampproject#23978) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some CSS transforms like a
translateusing % based value, orscale, can end up displaying blurry half pixel borders (see attached issue).There are many hacks available to work around it, like
backface-visibilityfortranslateproperties, or using JavaScript to compute a rounded number of pixels. However, the only one I found that works with bothscaleandtranslateis thisperspectiveproperty.It doesn't seem to affect GPU memory usage and fixes the issue across browsers.
Fixes #16626