🏗 Update Local AMP extension to allow custom base URLs#24029
Merged
rsimha merged 2 commits intoampproject:masterfrom Aug 20, 2019
Merged
🏗 Update Local AMP extension to allow custom base URLs#24029rsimha merged 2 commits intoampproject:masterfrom
rsimha merged 2 commits intoampproject:masterfrom
Conversation
Member
Author
|
/cc @wassgha |
1 task
wassgha
approved these changes
Aug 18, 2019
Contributor
wassgha
left a comment
There was a problem hiding this comment.
LGTM based on review from the other PR
rsimha
approved these changes
Aug 20, 2019
Contributor
There was a problem hiding this comment.
LGTM based on @wassgha's review at #23213 (comment) :)
westonruter
added a commit
to westonruter/amphtml
that referenced
this pull request
Aug 20, 2019
* 'master' of github.com:ampproject/amphtml: (32 commits) ✨ Make tweet id a bindable attribute (ampproject#23953) 🏗 Update Local AMP extension to allow custom base URLs (ampproject#24029) 🏗 Improve serving from non-localhost host (ampproject#24066) Preventing half pixels. (ampproject#24050) Update callout-vendors.js (ampproject#23218) 🏗 Fixes to `check-package-manager.js` (ampproject#24060) Rename AMP_MODE to __AMP_MODE. (ampproject#24052) Story media performance metrics. (ampproject#23962) Updating Story amp-sidebar width documentation. (ampproject#23894) Fixes race condition in amp-video-iframe (ampproject#24033) Rename ampExtendedElements to __AMP_EXTENDED_ELEMENTS (ampproject#24056) 🏗🚮 Enable property inlining (ampproject#24053) ✨amp-ads: Added optional params for Directadvert network (ampproject#23724) <amp-experiment> style mutation fix and improvment (ampproject#23669) 🐛 Allow http protocol for noscript > img fallbacks for parity with amp-img (ampproject#21686) 🏗 Refactor transform-log-asserts (ampproject#24028) Automatically preconnect to source origins on page loads. (ampproject#24045) Support visibility API in the ampdoc (ampproject#23799) Amphtml visual tests should use relative path against root (ampproject#24042) FIX: check all fields' dirtiness on AMP form init (ampproject#23978) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is split off from #23213.
When calling
gulp serveyou can specify a host to use that is different from the defaultlocalhost:8000(default arguments--host=localhostand--port=8000). However, the Local AMP browser extension does not support anything but the default. This PR updates the extension popup to include a URL input field for the actual base URL to be supplied (e.g.https://amphtml.lndo.site/).Importantly, this allows for the extension to be successfully used on HTTPS sites. Previously, I would get insecure mixed content warnings on HTTPS sites since the script URLs would be loaded from
http://localhost:8000.