Skip to content

🐛 Update callout-vendors.js for Navegg#23218

Merged
lannka merged 1 commit intoampproject:masterfrom
eohashi:patch-2
Aug 20, 2019
Merged

🐛 Update callout-vendors.js for Navegg#23218
lannka merged 1 commit intoampproject:masterfrom
eohashi:patch-2

Conversation

@eohashi
Copy link
Copy Markdown
Contributor

@eohashi eohashi commented Jul 9, 2019

Instructions:

  • Pick a meaningful title for your pull request. (Use sentence case.)
    • Prefix the title with an emoji to identify what is being done. (Copy-paste the emoji itself (not the :code:) from the list below.)
    • Do not overuse punctuation in the title (like (chore):).
    • If it is helpful, use a simple prefix (like ProjectX: Implement some feature).
  • Enter a succinct description that says why the PR is necessary, and what it does.
    • Mention the GitHub issue that is being addressed by the pull request.
    • The keywords Fixes, Closes, or Resolves followed the issue number will automatically close the issue.

Example of a good description:

  • Implement aspect X
  • Leave out feature Y because of A
  • Improve performance by B
  • Improve accessibility by C

Emojis for categorizing pull requests:

✨ New feature (:sparkles:)
🐛 Bug fix (:bug:)
🔥 P0 fix (:fire:)
✅ Tests (:white_check_mark:)
🚀 Performance improvements (:rocket:)
🖍 CSS / Styling (:crayon:)
♿ Accessibility (:wheelchair:)
🌐 Internationalization (:globe_with_meridians:)
📖 Documentation (:book:)
🏗 Infrastructure / Tooling / Builds / CI (:building_construction:)
⏪ Reverting a previous change (:rewind:)
♻️ Refactoring (like moving around code w/o any changes) (:recycle:)
🚮 Deleting code (:put_litter_in_its_place:)

@thomaskauai
Copy link
Copy Markdown

+1

@eohashi
Copy link
Copy Markdown
Contributor Author

eohashi commented Aug 20, 2019

@lannka

@lannka lannka self-requested a review August 20, 2019 16:56
@lannka lannka merged commit 36480f1 into ampproject:master Aug 20, 2019
westonruter added a commit to westonruter/amphtml that referenced this pull request Aug 20, 2019
* 'master' of github.com:ampproject/amphtml: (32 commits)
  ✨ Make tweet id a bindable attribute (ampproject#23953)
  🏗 Update Local AMP extension to allow custom base URLs (ampproject#24029)
  🏗 Improve serving from non-localhost host (ampproject#24066)
  Preventing half pixels. (ampproject#24050)
  Update callout-vendors.js (ampproject#23218)
  🏗 Fixes to `check-package-manager.js` (ampproject#24060)
  Rename AMP_MODE to __AMP_MODE. (ampproject#24052)
  Story media performance metrics. (ampproject#23962)
  Updating Story amp-sidebar width documentation. (ampproject#23894)
  Fixes race condition in amp-video-iframe (ampproject#24033)
  Rename ampExtendedElements to __AMP_EXTENDED_ELEMENTS (ampproject#24056)
  🏗🚮 Enable property inlining (ampproject#24053)
  ✨amp-ads: Added optional params for Directadvert network (ampproject#23724)
  <amp-experiment> style mutation fix and improvment (ampproject#23669)
  🐛 Allow http protocol for noscript > img fallbacks for parity with amp-img (ampproject#21686)
  🏗 Refactor transform-log-asserts (ampproject#24028)
  Automatically preconnect to source origins on page loads. (ampproject#24045)
  Support visibility API in the ampdoc (ampproject#23799)
  Amphtml visual tests should use relative path against root (ampproject#24042)
  FIX: check all fields' dirtiness on AMP form init (ampproject#23978)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants