Raise PHPStan level to 4 in lib/common#4686
Merged
westonruter merged 5 commits intodevelopfrom May 15, 2020
Merged
Conversation
westonruter
reviewed
May 13, 2020
Member
westonruter
left a comment
There was a problem hiding this comment.
Does this warrant being part of v1.5.4?
| $statusCode = $response->getStatusCode(); | ||
|
|
||
| if (200 < $statusCode || $statusCode >= 300) { | ||
| if ($statusCode < 200 || $statusCode >= 300) { |
Member
There was a problem hiding this comment.
This bug means that the fallback stylesheet would almost always be used?
Collaborator
Author
There was a problem hiding this comment.
Yes, we should backport this.
Member
There was a problem hiding this comment.
Cool. Then I'll squash merge and cherry-pick.
3 tasks
pierlon
approved these changes
May 15, 2020
| - | ||
| message: '#^If condition is always false\.$#' | ||
| path: 'src/Dom/Document.php' | ||
| # See https://github.com/phpstan/phpstan/issues/3291 |
Contributor
There was a problem hiding this comment.
I assume your PR on the phpstan repo (phpstan/phpstan-src#203) fixes this. Once a new release is made with that change we should be able to remove this.
Collaborator
Author
There was a problem hiding this comment.
Yes. The general idea is to update to latest PHPStan and revisit the exceptions here each time we bump the level.
Collaborator
There was a problem hiding this comment.
FWIW I think PHPStan will complain if an exception is no longer encountered. In other words, it will tell you that you can remove it :-)
Collaborator
Author
There was a problem hiding this comment.
Yes, indeed, it does.
westonruter
pushed a commit
that referenced
this pull request
May 15, 2020
* Bump level to 4 * Add additional null typehint * Add additional null typehint * Fix bug with status code comparison * Rewrite logic and add exception for false positive when checking libxml version
westonruter
added a commit
that referenced
this pull request
May 15, 2020
…ve-collection-schema-type * 'develop' of github.com:ampproject/amp-wp: Raise PHPStan level to 4 in lib/common (#4686) Update dependency uuid to v8 Update dependency webpack to v4.43.0 Update dependency eslint-plugin-jest to v23.11.0 Update dependency eslint-plugin-react to v7.20.0 (#4691) Update dependency postcss to v7.0.30 (#4649) Update dependency moment to v2.25.3 (#4639) Update dependency babel-jest to v26 (#4652) Update dependency uuid to v7.0.3 (#4490) Update dependency wp-coding-standards/wpcs to v2.3.0 (#4721) Suppress Site Health ICU test if site or home URL is not an IDN (#4698) Pin amp-experiment to v0.1 (#4690) Strip multiple BOM characters (#4683) Strip leading BOM and whitespace and trailing HTML comment before parsing validation response JSON (#4679) Disable share icons Use amp-embedly-card for Tiktok embeds Update dependency xwp/wp-dev-lib to v1.6.4 Update dependency eslint to v7 Update dependency terser-webpack-plugin to v2.3.6
westonruter
added a commit
that referenced
this pull request
May 15, 2020
…-phpstan-to-level-4 * 'develop' of github.com:ampproject/amp-wp: Update dependency @wordpress/scripts to v9.1.0 Update dependency @wordpress/jest-puppeteer-axe to v1.8.0 Update dependency @wordpress/url to v2.15.0 Update dependency @wordpress/plugins to v2.16.0 Raise PHPStan level to 4 in lib/common (#4686) Update dependency uuid to v8 Update dependency webpack to v4.43.0 Update dependency eslint-plugin-jest to v23.11.0 Update dependency eslint-plugin-react to v7.20.0 (#4691) Update dependency postcss to v7.0.30 (#4649) Update dependency moment to v2.25.3 (#4639) Update dependency babel-jest to v26 (#4652) Update dependency uuid to v7.0.3 (#4490) Update dependency wp-coding-standards/wpcs to v2.3.0 (#4721) Update dependency @wordpress/e2e-test-utils to v4.7.0 Suppress Site Health ICU test if site or home URL is not an IDN (#4698) Pin amp-experiment to v0.1 (#4690) Disable share icons Use amp-embedly-card for Tiktok embeds Update dependency terser-webpack-plugin to v2.3.6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the following issues that PHPStan detected at level 4:
Fixes #4379
Checklist