Skip to content

Strip multiple BOM characters#4683

Merged
westonruter merged 1 commit intodevelopfrom
fix/json-parsing-resiliency-2
May 12, 2020
Merged

Strip multiple BOM characters#4683
westonruter merged 1 commit intodevelopfrom
fix/json-parsing-resiliency-2

Conversation

@westonruter
Copy link
Copy Markdown
Member

@westonruter westonruter commented May 12, 2020

Summary

Fixes #4678
Amends #4679

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@westonruter westonruter merged commit 7f36afd into develop May 12, 2020
@westonruter westonruter deleted the fix/json-parsing-resiliency-2 branch May 12, 2020 06:59
westonruter added a commit that referenced this pull request May 12, 2020
westonruter added a commit that referenced this pull request May 12, 2020
…n-suppression

* 'develop' of github.com:ampproject/amp-wp:
  Strip multiple BOM characters (#4683)
  Strip leading BOM and whitespace and trailing HTML comment before parsing validation response JSON (#4679)
  Update dependency xwp/wp-dev-lib to v1.6.4
  Update dependency eslint to v7
westonruter added a commit that referenced this pull request May 13, 2020
…/reader-mode-themes

* 'develop' of github.com:ampproject/amp-wp: (59 commits)
  Strip multiple BOM characters (#4683)
  Strip leading BOM and whitespace and trailing HTML comment before parsing validation response JSON (#4679)
  Update dependency xwp/wp-dev-lib to v1.6.4
  Update dependency eslint to v7
  Remove unused RuntimeException
  Use explicit string type instead of generic array in return
  Avoid method map and replace with a switch
  Defer removal of attributes until after layout application
  Fix post preview in Reader mode (#4665)
  Ensure that source map comment is preserved at the end of amp-custom.css
  Pass DOMAttr instances rather than attribute name and value as separate args
  Enable SSR by default, remove use of WP_DEBUG as a signal. (#4669)
  Use padding-top and override regular inline style for heights
  Update php-parallel-lint dependency to new name
  Use :first-child to reference sizer in CSS
  Update dependency @wordpress/babel-preset-default to v4.12.1 (#4494)
  Fix error type for bad sizes test
  Provide more precise error for thrown exception
  Test precise error messages
  Fix attribute name in error messages
  ...
westonruter added a commit that referenced this pull request May 15, 2020
…ve-collection-schema-type

* 'develop' of github.com:ampproject/amp-wp:
  Raise PHPStan level to 4 in lib/common (#4686)
  Update dependency uuid to v8
  Update dependency webpack to v4.43.0
  Update dependency eslint-plugin-jest to v23.11.0
  Update dependency eslint-plugin-react to v7.20.0 (#4691)
  Update dependency postcss to v7.0.30 (#4649)
  Update dependency moment to v2.25.3 (#4639)
  Update dependency babel-jest to v26 (#4652)
  Update dependency uuid to v7.0.3 (#4490)
  Update dependency wp-coding-standards/wpcs to v2.3.0 (#4721)
  Suppress Site Health ICU test if site or home URL is not an IDN (#4698)
  Pin amp-experiment to v0.1 (#4690)
  Strip multiple BOM characters (#4683)
  Strip leading BOM and whitespace and trailing HTML comment before parsing validation response JSON (#4679)
  Disable share icons
  Use amp-embedly-card for Tiktok embeds
  Update dependency xwp/wp-dev-lib to v1.6.4
  Update dependency eslint to v7
  Update dependency terser-webpack-plugin to v2.3.6
@westonruter westonruter added this to the v1.5.4 milestone Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Signed the Google CLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Byte order mark (BOM) breaks ability to do validation

3 participants