Skip to content

Enable SSR by default, remove use of WP_DEBUG as a signal.#4669

Merged
westonruter merged 1 commit intodevelopfrom
fix/4667-enable-ssr-by-default
May 7, 2020
Merged

Enable SSR by default, remove use of WP_DEBUG as a signal.#4669
westonruter merged 1 commit intodevelopfrom
fix/4667-enable-ssr-by-default

Conversation

@adamsilverstein
Copy link
Copy Markdown
Collaborator

@adamsilverstein adamsilverstein commented May 7, 2020

Summary

Enable SSR by default, remove use of WP_DEBUG as a signal.

Any tests that need to be updated or added for this?

Fixes #4667

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@googlebot googlebot added the cla: yes Signed the Google CLA label May 7, 2020
@westonruter westonruter merged commit b9556a1 into develop May 7, 2020
@westonruter westonruter deleted the fix/4667-enable-ssr-by-default branch May 7, 2020 19:02
westonruter added a commit that referenced this pull request May 7, 2020
…preview-reader-mode

* 'develop' of github.com:ampproject/amp-wp:
  Enable SSR by default, remove use of WP_DEBUG as a signal. (#4669)
  Update dependency @wordpress/babel-preset-default to v4.12.1 (#4494)
  Revert "Move .gitattributes file into lib/optimizer folder"
  Move .gitattributes file into lib/optimizer folder
  Remove redundant JSONOBJECT_AS_ARRAY constant
  Use substr() instead of a replacement for removing the leading comment
  Add git attributes file to mark certain file as being generated
  Remove unused import
  Complete stubbed requests data
  Add more tests to assert runtime transformer behavior
  Remove runtime style tag if stylesheet is linked
  Nake use of styles provided via config if available
  Add STYLES configuration key to AmpRuntimeCss transformer
  Adapt spec test to extract configuration arguments from input files
  Update spec files
  Add puppeteer as a peer dependency
  Update dependency @wordpress/block-editor to v3.10.0
  Update dependency xwp/wp-dev-lib to v1.6.3
westonruter added a commit that referenced this pull request May 13, 2020
…/reader-mode-themes

* 'develop' of github.com:ampproject/amp-wp: (59 commits)
  Strip multiple BOM characters (#4683)
  Strip leading BOM and whitespace and trailing HTML comment before parsing validation response JSON (#4679)
  Update dependency xwp/wp-dev-lib to v1.6.4
  Update dependency eslint to v7
  Remove unused RuntimeException
  Use explicit string type instead of generic array in return
  Avoid method map and replace with a switch
  Defer removal of attributes until after layout application
  Fix post preview in Reader mode (#4665)
  Ensure that source map comment is preserved at the end of amp-custom.css
  Pass DOMAttr instances rather than attribute name and value as separate args
  Enable SSR by default, remove use of WP_DEBUG as a signal. (#4669)
  Use padding-top and override regular inline style for heights
  Update php-parallel-lint dependency to new name
  Use :first-child to reference sizer in CSS
  Update dependency @wordpress/babel-preset-default to v4.12.1 (#4494)
  Fix error type for bad sizes test
  Provide more precise error for thrown exception
  Test precise error messages
  Fix attribute name in error messages
  ...
@pierlon pierlon added this to the v1.5.4 milestone Jun 2, 2020
@schlessera schlessera added Optimizer WS:Perf Work stream for Metrics, Performance and Optimizer labels Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Signed the Google CLA Optimizer WS:Perf Work stream for Metrics, Performance and Optimizer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Discontinue disabling Optimizer SSR when WP_DEBUG is enabled

5 participants