Skip to content

Discontinue disabling Optimizer SSR when WP_DEBUG is enabled #4667

@westonruter

Description

@westonruter

Feature description

Optimizer SSR is currently disabled by default when WP_DEBUG is enabled:

$enable_ssr = array_key_exists( ConfigurationArgument::ENABLE_SSR, $args )
? $args[ ConfigurationArgument::ENABLE_SSR ]
: ! ( defined( 'WP_DEBUG' ) && WP_DEBUG );

It seems more sites have WP_DEBUG enabled in production than I expected, so this is causing SSR to be disabled on sites when it doesn't need to be. Also, the decision to use WP_DEBUG as a signal to turn off SSR was not set in stone and I've wavered as to whether it should be used (and perhaps is_user_logged_in() would be better signal). In any case, we can just default to having it enabled always.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation brief

QA testing instructions

Demo

Changelog entry

Metadata

Metadata

Assignees

No one assigned

    Labels

    OptimizerWS:PerfWork stream for Metrics, Performance and Optimizer

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions