-
Notifications
You must be signed in to change notification settings - Fork 382
Closed
Labels
OptimizerWS:PerfWork stream for Metrics, Performance and OptimizerWork stream for Metrics, Performance and Optimizer
Milestone
Description
Feature description
Optimizer SSR is currently disabled by default when WP_DEBUG is enabled:
amp-wp/includes/class-amp-theme-support.php
Lines 2164 to 2166 in 845ba09
| $enable_ssr = array_key_exists( ConfigurationArgument::ENABLE_SSR, $args ) | |
| ? $args[ ConfigurationArgument::ENABLE_SSR ] | |
| : ! ( defined( 'WP_DEBUG' ) && WP_DEBUG ); |
It seems more sites have WP_DEBUG enabled in production than I expected, so this is causing SSR to be disabled on sites when it doesn't need to be. Also, the decision to use WP_DEBUG as a signal to turn off SSR was not set in stone and I've wavered as to whether it should be used (and perhaps is_user_logged_in() would be better signal). In any case, we can just default to having it enabled always.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation brief
QA testing instructions
Demo
Changelog entry
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
OptimizerWS:PerfWork stream for Metrics, Performance and OptimizerWork stream for Metrics, Performance and Optimizer