-
Notifications
You must be signed in to change notification settings - Fork 382
Raise PHPStan level for the amp/common package to 4 #4379
Copy link
Copy link
Closed
Labels
EnhancementNew feature or improvement of an existing oneNew feature or improvement of an existing oneP1Medium priorityMedium priority
Milestone
Description
Feature description
The Common package (ampproject/common) is currently sitting at and enforcing level 3 of PHPStan static analysis.
There are 5 errors that need to be fixed so that we can raise the level to 4 and enforce this new quality level in Travis CI.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
- PHPStan does not show any detected errors when run on level 4.
Implementation brief
- Change the level to
4in the filephpstan.neon.dist. - Run
composer analyze. - Fix detected errors until no more are found.
QA testing instructions
Demo
Changelog entry
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
EnhancementNew feature or improvement of an existing oneNew feature or improvement of an existing oneP1Medium priorityMedium priority