Keyboard & Right-Click Menu Copy + Paste by miina · Pull Request #3083 · ampproject/amp-wp

miina · 2019-08-23T12:29:46Z

Closes #2996
Closes #2990
Closes #2989

Todo:

swissspidy · 2019-08-23T15:47:50Z

Nice, can‘t wait to test this!

…copy-paste

miina · 2019-08-28T10:50:23Z

There is an issue with keyboard copying, namely, the CopyHandler doesn't always trigger for many blocks, looks like it triggers only if the block is selected in some specific way (so far first dragging the block and then copying seems to work the best). This seems to be an issue with regular post and the default block editor as well, e.g. adding an image block, clicking on it, and then pasting into empty paragraph sometimes copies the block into clipboard but not always.

The following blocks seem to work OK:

text
title
author
date
Embed

The rest of the blocks are not reliably copied to clipboard. If the block gets copied then everything works as expected.

Debugged the upstream CopyHandler to verify it's not reliably triggering. Also tried adding a custom copy handler by using onCopyCapture instead, also tried adding the ` handler directly wrapping each block, still not triggering for most of the blocks.

@swissspidy Any thoughts on this?

Otherwise, looks like the Right-Click menu might be the way to reliably implement this feature.

swissspidy · 2019-08-28T16:26:00Z

Haven't gotten around to test this myself yet, but what you describe sounds like an upstream bug (or perhaps even a browser issue) that we can't work around ourselves. Is there any related issue in the Gutenberg repository about the copy handler?

Otherwise, looks like the Right-Click menu might be the way to reliably implement this feature.

👍

miina · 2019-08-28T16:30:09Z

Is there any related issue in the Gutenberg repository about the copy handler?

Couldn't find it as much as I checked at least, can look some more. I'll try testing it again later with clean WP Install (with AMP Plugin completely disabled) to see if that's still the case and then open an issue if yes.

Reorganize adding block actions.

assets/src/stories-editor/components/right-click-menu/index.js

Co-Authored-By: Pascal Birchler <pascalb@google.com>

…to add/2996-keyboard-copy-paste # Conflicts: # assets/src/stories-editor/blocks/amp-story-page/edit.js # assets/src/stories-editor/helpers/index.js # assets/src/stories-editor/index.js

googlebot · 2019-09-10T15:46:15Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

googlebot · 2019-09-10T21:18:54Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

swissspidy

Everything is working as expected:

Keyboard copy/paste
right click context menu for copying and pasting
browser clipboard permission dialog

spacedmonkey · 2019-09-12T09:46:13Z

E2E tests are passing. Can someone re-review this?

spacedmonkey

👍

…keep-attributes-with-mustache-placeholders-intact * 'develop' of github.com:ampproject/amp-wp: (113 commits) This converts the keyboard cut handler to equal a copy handler to avoid bugs Fix aria-label adding helper function Remove extra line I added in resolving merge conflict Fix alignment of arrow Fix custom CTA text for page attachment Fix cut handler by shortcut Cleanup of duplicated comment Add unit testing to `addVideoAriaLabel` Remove unused piece of code Remove Cloudflare AMP cache since deprecated Handle cut keyboard requests. (#3231) Page Attachment block (#3035) Keyboard & Right-Click Menu Copy + Paste (#3083) Animation Previews (#3104) Make internal methods inaccessible Omit the ecosystem link also when using a core theme Add skipped e2e test for the video block Add array_colum() pollyfill for PHP < 5.5 Add asserts to make sure we are not enqueueing both versions of dashicons Remove useless variable ...

miina added 2 commits August 23, 2019 15:01

Start adding pasteHandler.

95f6d9d

Add PropTypes and missing props.

9876f47

googlebot added the cla: yes Signed the Google CLA label Aug 23, 2019

miina changed the title ~~Keyboard Copy + Paste~~ [WIP] Keyboard Copy + Paste Aug 23, 2019

Add placeholder for ensuring allowed blocks.

cdbe412

miina added 3 commits August 27, 2019 18:54

Merge remote-tracking branch 'origin/develop' into add/2996-keyboard-…

ebebf5a

…copy-paste

Allow copying only allowed blocks.

101e54a

Ensure only allowed child blocks can be pasted.

3b525b4

miina added 3 commits August 28, 2019 18:36

Start adding right click menu.

c9a72dd

Add missing file.

f78df6b

Add duplicating block.

b2d2050

miina changed the title ~~[WIP] Keyboard Copy + Paste~~ [WIP] Keyboard & Right-Click Copy + Paste Aug 28, 2019

miina added 3 commits August 28, 2019 20:41

Refactor code.

786fbc6

Improve style.

b8485e4

Adjust popover position.

25e64a4

miina changed the title ~~[WIP] Keyboard & Right-Click Copy + Paste~~ [WIP] Keyboard & Right-Click Menu Copy + Paste Aug 28, 2019

miina added 4 commits August 29, 2019 12:13

Add Copy button.

f59c566

Add Cut button.

b7024d2

Add PropTypes.

6261728

Reorganize adding block actions.

Add workaround for Paste button.

c49bfd1

miina commented Aug 29, 2019

View reviewed changes

assets/src/stories-editor/components/right-click-menu/index.js Outdated Show resolved Hide resolved

swissspidy reviewed Aug 29, 2019

View reviewed changes

assets/src/stories-editor/components/right-click-menu/index.js Show resolved Hide resolved

miina added 4 commits August 29, 2019 16:52

Use store instead of state for storing copied markup.

390ddb2

Ask permissions for pasting from clipboard.

25e3c48

Merge develop

fdb5c79

Make sure navigator.clipboard exists before using it.

48f5192

spacedmonkey and others added 5 commits September 10, 2019 16:42

Allow blocks to be copied many times.

ddce164

Fix pasting text elements will now paste them when the cusor is.

66953f1

Use templates

15c7731

Co-Authored-By: Pascal Birchler <pascalb@google.com>

Change variable names.

c4f3b2b

Merge remote-tracking branch 'origin/add/2996-keyboard-copy-paste' in…

3cff1e2

…to add/2996-keyboard-copy-paste # Conflicts: # assets/src/stories-editor/blocks/amp-story-page/edit.js # assets/src/stories-editor/helpers/index.js # assets/src/stories-editor/index.js

googlebot added cla: no Has not signed the Google CLA and removed cla: yes Signed the Google CLA labels Sep 10, 2019

spacedmonkey added 2 commits September 10, 2019 16:50

Remove repeated helper function.

a5eac06

Only place blocks that are movable next to cusor.

8dbf87b

googlebot added cla: yes Signed the Google CLA and removed cla: no Has not signed the Google CLA labels Sep 10, 2019

swissspidy approved these changes Sep 11, 2019

View reviewed changes

spacedmonkey force-pushed the add/2996-keyboard-copy-paste branch from 27023d1 to 8dbf87b Compare September 11, 2019 16:24

spacedmonkey added 2 commits September 11, 2019 17:26

Use class prop

32573e7

Uncommnet out code.

a425d0b

spacedmonkey force-pushed the add/2996-keyboard-copy-paste branch from ecf6b79 to a425d0b Compare September 11, 2019 17:28

spacedmonkey added 2 commits September 11, 2019 18:59

Merge branch 'develop' into add/2996-keyboard-copy-paste

6152350

Return tests.

593086a

spacedmonkey force-pushed the add/2996-keyboard-copy-paste branch from c686037 to 593086a Compare September 11, 2019 18:01

spacedmonkey and others added 3 commits September 12, 2019 10:13

Wait for image and video blocks to be inserted.

77c7a7d

Merge branch 'develop' into add/2996-keyboard-copy-paste

a07e10e

Fix lint

d9aee22

spacedmonkey approved these changes Sep 12, 2019

View reviewed changes

swissspidy merged commit c406f2a into develop Sep 12, 2019

swissspidy deleted the add/2996-keyboard-copy-paste branch September 12, 2019 09:58

swissspidy mentioned this pull request Sep 16, 2019

Fix issue with cut #3246

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Keyboard & Right-Click Menu Copy + Paste#3083

Keyboard & Right-Click Menu Copy + Paste#3083
swissspidy merged 113 commits intodevelopfrom
add/2996-keyboard-copy-paste

miina commented Aug 23, 2019 •

edited

Loading

Uh oh!

swissspidy commented Aug 23, 2019

Uh oh!

miina commented Aug 28, 2019

Uh oh!

swissspidy commented Aug 28, 2019

Uh oh!

miina commented Aug 28, 2019

Uh oh!

Uh oh!

Uh oh!

googlebot commented Sep 10, 2019

Uh oh!

googlebot commented Sep 10, 2019

Uh oh!

swissspidy left a comment

Uh oh!

spacedmonkey commented Sep 12, 2019

Uh oh!

spacedmonkey left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

miina commented Aug 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

swissspidy commented Aug 23, 2019

Uh oh!

miina commented Aug 28, 2019

Uh oh!

swissspidy commented Aug 28, 2019

Uh oh!

miina commented Aug 28, 2019

Uh oh!

Uh oh!

Uh oh!

googlebot commented Sep 10, 2019

Uh oh!

googlebot commented Sep 10, 2019

Uh oh!

swissspidy left a comment

Choose a reason for hiding this comment

Uh oh!

spacedmonkey commented Sep 12, 2019

Uh oh!

spacedmonkey left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

miina commented Aug 23, 2019 •

edited

Loading