Conversation
This way everything runs through PostCSS and Autoprefixer
3fa43a6 to
073c56a
Compare
|
This is awesome! It (almost 😄) works! 🎉 "Almost" works since rotation doesn't seem to work anymore, probably we'll need to add another wrapper for the animations so that it wouldn't collide with the rotation wrapper. One additional comment from functional testing: |
|
Thanks for testing @miina!
The issue wasn't a conflict between the Resizing and rotation now works again as expected.
As long as the animation is playing, resize handles should actually be hidden: amp-wp/assets/src/stories-editor/style.css Lines 246 to 251 in 4353af3 I'll try to improve that though 👍 |
|
Thanks for the fixes, will test again shortly.
Maybe it's the set transition time why it takes some time to hide? |
|
Uhm, I think I just found a bug related to animation 🚨 When a block is saved, the Edit: Fixed now |
|
Should the page animation inspector panel perhaps include a list of the animations on the page? Or at least a count of them? Currently even if there are no animations, the button "Play all animations" is still there and active even though nothing happens on click. Should the button perhaps be disabled if there are no animations on the page? Maybe the button text could simply be |
This was suggested by Jonny as well above, but I had some reservations about this being the right place for such a list. See #3104 (comment). I do like the suggestion of using a count in the button label though.
Hmm I already implemented this in 41138b0 🤔 There's even a test for it. But perhaps there is some edge case. Will look into it. |
If I add an element with an animation, the "play all" button appears on the page. If I remove the animation from the element, the "play all" button is correctly removed. But if I delete the element outright without first setting the animation to "none", the "play all" button sticks around still thinking there's an animation on the page. |
|
If I create a cascading sequence of animations, so element 1 plays immediately, element 2 plays after element 1 and element 3 plays after element 2, the "play all animations" action gets stuck after the second animation - the third one never starts. This does work correctly in "preview", it's only in the editor with the "play all animations", that third level animations don't play. I also managed to set up a longer chain, where one of the chained animations played immediately even though it was set to play after an element, that never actually played. I can't recreate it though. |
While the page animation playback is in progress (or stuck as in this case and will never complete until I press the "stop" button), I can still select other blocks on the page, change them, move them, delete them, etc. It might be a good idea to abort the animation playback as soon as the page loses focus/selection. |
First pass, not fully DRY yet.
Gutenberg has a |
Ah! Since the animation store doesn't really do garbage collection for deleted elements, the list included invalid items. Can circumvent this by filtering the list directly in the component. |
This should be fixed now |
Haven't found an easy way to do this. I am inclined to leave this extra hardening for later so we can get this in for now. |
…keep-attributes-with-mustache-placeholders-intact * 'develop' of github.com:ampproject/amp-wp: (113 commits) This converts the keyboard cut handler to equal a copy handler to avoid bugs Fix aria-label adding helper function Remove extra line I added in resolving merge conflict Fix alignment of arrow Fix custom CTA text for page attachment Fix cut handler by shortcut Cleanup of duplicated comment Add unit testing to `addVideoAriaLabel` Remove unused piece of code Remove Cloudflare AMP cache since deprecated Handle cut keyboard requests. (#3231) Page Attachment block (#3035) Keyboard & Right-Click Menu Copy + Paste (#3083) Animation Previews (#3104) Make internal methods inaccessible Omit the ecosystem link also when using a core theme Add skipped e2e test for the video block Add array_colum() pollyfill for PHP < 5.5 Add asserts to make sure we are not enqueueing both versions of dashicons Remove useless variable ...
Needed because #3104 added a new wrapping element



Fixes #3069.
Fixes #3070.
Example: