Fix AMP Story editor compatibility with code editor#3007
Merged
swissspidy merged 10 commits intodevelopfrom Aug 12, 2019
Merged
Fix AMP Story editor compatibility with code editor#3007swissspidy merged 10 commits intodevelopfrom
swissspidy merged 10 commits intodevelopfrom
Conversation
Collaborator
|
Looks good! Might be a nice thing to add a small e2e test for. Will have a look. |
swissspidy
approved these changes
Aug 12, 2019
miina
approved these changes
Aug 12, 2019
| await expect( page ).not.toMatchElement( '.block-editor-writing-flow__click-redirect' ); | ||
|
|
||
| await switchEditorModeTo( 'Code' ); | ||
| await page.click( '.edit-post-more-menu [aria-label="More tools & options"]' ); |
Contributor
There was a problem hiding this comment.
Could also use clickButtonByLabel here which also waits until the selector becomes available, although its availability is not really an issue here.
westonruter
added a commit
that referenced
this pull request
Aug 12, 2019
…p-bind-syntax * 'develop' of github.com:ampproject/amp-wp: RTLCSS all the things (#2977) Fix AMP Story editor compatibility with code editor (#3007) Update dependency core-js to v3.2.1 (#3011) Update amphtml validator spec to v1907301630320 (#3003) Improve handling of unlisted Vimeo videos (#2986) Always hide AMP admin menu item and compatibility tool menu ite… (#3005) Update dependency dom-scroll-into-view to v2.0.1 (#3008) Hide tooltips that should be hidden (#2988)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I encountered a couple bugs when attempting the story editor after having been in code editor mode. First of all:
There was an apparent missing check for whether the
.block-editor-writing-flow__click-redirectelement exists before removing it. So this is fixed in ad8e115.After fixing this, the editor was able to load without causing an error, but when switching to visual editor I saw duplicated controls:
This is due to not checking if the
#amp-story-editorelement already exists in the page. Fixed by 4c67fbf.Also fixes #3010.