Conversation
| @@ -0,0 +1,13 @@ | |||
| { | |||
There was a problem hiding this comment.
This is the default config as mentioned at https://rtlcss.com/learn/usage-guide/cli/
Without a config file there are warnings.
|
Merge conflict in |
# Conflicts: # .stylelintignore
westonruter
left a comment
There was a problem hiding this comment.
- Make sure RTL stylesheets are actually loaded by WordPress
Yeah, this is not happening yet. In order to get an RTL stylesheet to load, this has to be done for each plugin-registered style:
wp_styles()->add_data( $handle, 'rtl', true );|
Tested the changes using both the RTL Tester plugin and by temporarily switching the site language to Arabic. Visited all the admin pages, the customizer, and the frontend and everything looked good. The only issue is with the AMP Stories editor. I've opened #3012 to address that separately. |
|
@swissspidy I'm not seeing the “Enable AMP” checkbox for some reason:
|
|
@westonruter I see it just fine in both Transitional and Standard mode:
|
|
I think
|
This comment has been minimized.
This comment has been minimized.
|
checking... |
|
Turns out to be because Gutenberg was not active on the environment. So not related to RTL. |
…p-bind-syntax * 'develop' of github.com:ampproject/amp-wp: RTLCSS all the things (#2977) Fix AMP Story editor compatibility with code editor (#3007) Update dependency core-js to v3.2.1 (#3011) Update amphtml validator spec to v1907301630320 (#3003) Improve handling of unlisted Vimeo videos (#2986) Always hide AMP admin menu item and compatibility tool menu ite… (#3005) Update dependency dom-scroll-into-view to v2.0.1 (#3008) Hide tooltips that should be hidden (#2988)
See #2976.
To do: