Hide tooltips that should be hidden#2988
Merged
swissspidy merged 1 commit intodevelopfrom Aug 12, 2019
Merged
Conversation
Member
|
Where are you seeing these containers being shown? I don't see them at all on any of the compatibility tool admin screens. |
Collaborator
Author
|
On the Error Index screen, the Validated URLs screen, and on the Validated URLs details screen. Example:
Happens on my personal site as well as locally on my AMP plugin dev environment. |
westonruter
approved these changes
Aug 9, 2019
Member
westonruter
left a comment
There was a problem hiding this comment.
Humm. I don't see it on my sites. Perhaps it's due to a browser extension you have? In any case, if this PR fixes the problem for you and the tooltips still appear when clicked, then I don't see any problem with merging this.
Collaborator
Author
|
Indeed seems to come from an injected stylesheet from an extension. I think it makes sense to explicitly hide the tooltip element to avoid such a conflict. |
westonruter
added a commit
that referenced
this pull request
Aug 12, 2019
…p-bind-syntax * 'develop' of github.com:ampproject/amp-wp: RTLCSS all the things (#2977) Fix AMP Story editor compatibility with code editor (#3007) Update dependency core-js to v3.2.1 (#3011) Update amphtml validator spec to v1907301630320 (#3003) Improve handling of unlisted Vimeo videos (#2986) Always hide AMP admin menu item and compatibility tool menu ite… (#3005) Update dependency dom-scroll-into-view to v2.0.1 (#3008) Hide tooltips that should be hidden (#2988)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hides tooltip containers that don't seem to be actually used themselves. Only their content is extracted in
amp-validation-tooltips.js.Before:
After: