Skip to content

Remove invalid license template.#209

Merged
ahcorde merged 4 commits intorollingfrom
no_bsd_2.0
Nov 24, 2025
Merged

Remove invalid license template.#209
ahcorde merged 4 commits intorollingfrom
no_bsd_2.0

Conversation

@tfoote
Copy link
Copy Markdown
Member

@tfoote tfoote commented Jan 31, 2020

Flagged in #109 this template is not a valid template for the BSD license.
The correct license was added in #205

The original author doesn't know where it came from: ros2/geometry2#222 (comment)

This will cause a lot of warnings/errors. But anyone who's using this template for legacy code has modified the license, naming it something that doesn't exist. It doesn't match with legacy code as flagged in ros2/geometry2#222 And anyone who has written new code is not using the standard BSD 3 clause license that we would want because they're trying to pass our linter which wouldn't pass with that in the past. The subtle differences will cause nightmares for due diligence efforts.

The longer we go the worse the problem will be. We could add a backwards compatibility period for a while but there's no way that we'll know that everyone has fixed things, and in that time more people will likely follow the incorrect template.

@tfoote
Remove invalid license template.
15477df 
Flagged in #109 this  template is not a valid template for a license.
The correct license was added in #205

Signed-off-by: Tully Foote <tfoote@osrfoundation.org>
@dirk-thomas
Copy link
Copy Markdown
Contributor

dirk-thomas commented Jan 31, 2020

What is the proposed roll out strategy for this breaking change?

This was referenced Jan 31, 2020
Merged
Merged
Merged
Merged
Merged
Merged
@tfoote
Copy link
Copy Markdown
Member Author

tfoote commented Jan 31, 2020

I have opened pull requests against every instance of this template in ros2.repos.

tfoote added a commit to ros2/rcutils that referenced this pull request Feb 1, 2020
@tfoote
FIx up bsd license
f8356d2 
re: ament/ament_lint#209

Signed-off-by: Tully Foote <tfoote@osrfoundation.org>
@cottsay
Copy link
Copy Markdown
Contributor

cottsay commented Jun 11, 2020

@tfoote, will #205 be backported to all supported ROS 2 releases? If not, I'll need to create a new branch to take this change in rqt_reconfigure.

@jacobperron jacobperron mentioned this pull request Mar 12, 2021
Merged
@audrow
Copy link
Copy Markdown
Contributor

audrow commented May 27, 2021

@tfoote, are we still interested in getting this in? Can I do anything to help?

@audrow audrow changed the base branch from master to rolling June 28, 2022 14:14
@ahcorde
Copy link
Copy Markdown
Contributor

ahcorde commented Nov 11, 2025 •
edited
Loading

Pulls: #209
Gist: https://gist.githubusercontent.com/ahcorde/fe3716267c4e8af1e3154554947793ea/raw/2c3862f578fe70152ba17ad8153c7f5958dea9c9/ros2.repos
BUILD args: --packages-above-and-dependencies ament_copyright
TEST args: --packages-above ament_copyright
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17459

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

This was referenced Nov 21, 2025
Merged
Merged
Merged
Merged
Merged
@ahcorde
Fixes
4448092 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@ahcorde
Copy link
Copy Markdown
Contributor

ahcorde commented Nov 21, 2025

Pulls: #209, ros-visualization/rqt_bag#205, ros-visualization/rqt_reconfigure#157, ros-perception/image_common#382, ros-visualization/interactive_markers#118, ros2/geometry2#855
Gist: https://gist.githubusercontent.com/ahcorde/8506efdf86b5f26338500f46f46bee88/raw/39a9f1d91928207d3f60149f95a9b15bad6b1daa/ros2.repos
BUILD args: --packages-above-and-dependencies ament_copyright
TEST args: --packages-above ament_copyright
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17573

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

tfoote
tfoote commented Nov 21, 2025
View reviewed changes
Copy link
Copy Markdown
Member Author

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for iterating on this and fixing the other places it's cropped up. The changes look good to me, pending CI, which looks like it's having issues right now.

@ahcorde ahcorde merged commit a1dfb25 into rolling Nov 24, 2025
3 checks passed
@ahcorde ahcorde deleted the no_bsd_2.0 branch November 24, 2025 08:57
@christophfroehlich christophfroehlich mentioned this pull request Dec 7, 2025
Merged
@christophfroehlich christophfroehlich mentioned this pull request Dec 7, 2025
Merged
@mini-1235 mini-1235 mentioned this pull request Dec 8, 2025
Merged
This was referenced Jan 14, 2026
Merged
Merged
Merged
Merged
Merged
ahcorde added a commit to ros-perception/image_pipeline that referenced this pull request Jan 19, 2026
@ahcorde @tfoote
Cleanup bsd 3 clause license usage (#1125)
0584612 
Related with ament/ament_lint#209

---------

Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
Co-authored-by: Tully Foote <tfoote@osrfoundation.org>
@christophfroehlich christophfroehlich mentioned this pull request Feb 1, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahcorde ahcorde ahcorde approved these changes

Assignees

@tfoote tfoote

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tfoote @dirk-thomas @cottsay @audrow @ahcorde