Add support for the 3-Clause BSD license#205
Merged
Conversation
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
dirk-thomas
reviewed
Jan 29, 2020
Contributor
dirk-thomas
left a comment
There was a problem hiding this comment.
Neither of the new test cases seems to be actually used / tested?
Contributor
Author
|
You are right, I forgot add them to the test_copyright.py file, I'll add them |
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
dirk-thomas
approved these changes
Jan 29, 2020
tfoote
approved these changes
Jan 30, 2020
Contributor
Author
|
CI:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add templates, and test cases to support 3-Clause BSD license as stated in:
https://opensource.org/licenses/BSD-3-Clause
This will allow to use the 3-Clause BSD license without the confusion caused on the 'BSD2' legacy license used in Ros packages (Although it's stated as license 2.0, it is similar to the BSD-3-Clause).
This should help solving geometry2/pull/222 and it will close #109