@tfoote I have reviewed again the licenses

I have seen that the licenses are The 3-Clause BSD License. But the only bsd license accepted is BSD 2.0 according with the code ament_copyright https://github.com/ament/ament_lint/blob/master/ament_copyright/ament_copyright/licenses.py#L41

I don't know where @clalancette got that copy of the license for ament/ament_lint@767257f

There's no such things at "Version 2" listed at https://spdx.org/licenses/BSD-3-Clause.html or https://opensource.org/licenses/BSD-3-Clause or as is in the code. That looks like an accidental copy and paste misstep.

In general though the linter needs to be able to accept any valid license. We can do minor whitespace updates if necessary but otherwise we cannot change the verbiage in the license on anything except what we've originally written. We talked about this a while ago and knew that the linters were too strict for applying to imported code. But we chose just not to turn them on instead of making them much more generic for expediency. If we want to turn them on for legacy code they will need to be updated to be more flexible.

I don't know where @clalancette got that copy of the license for ament/ament_lint@767257f

There's no such things at "Version 2" listed at https://spdx.org/licenses/BSD-3-Clause.html or https://opensource.org/licenses/BSD-3-Clause or as is in the code. That looks like an accidental copy and paste misstep.

Yeah, I'm honestly not sure where that came from now that I look at it. ament/ament_lint#109 addresses some of the same issue.

In general though the linter needs to be able to accept any valid license. We can do minor whitespace updates if necessary but otherwise we cannot change the verbiage in the license on anything except what we've originally written. We talked about this a while ago and knew that the linters were too strict for applying to imported code.

ament/ament_lint#75 (somewhat).

But we chose just not to turn them on instead of making them much more generic for expediency. If we want to turn them on for legacy code they will need to be updated to be more flexible.

For this PR, I'll suggest that we go back to the old copyright for now, and just disable the copyright check. Once we figure out the ament_lint situation, we can come back and turn it on.

@clalancette,

Excluded ament_copyright

should I include the license in the C++ code? beacuse cpplint is also failing because of the licence

should I include the license in the C++ code? beacuse cpplint is also failing because of the licence

I would say let's turn off cpplint for now as well. Once we resolve the situation in ament_lint, we can revisit this and reenable those.

Excluded cpplint too, should I run the CI?

• Linux
• Linux-aarch64
• macOS
• Windows
• Windows-container

• Linux
• Linux-aarch64
• macOS
• Windows
• Windows-container

• Linux
• Linux-aarch64
• macOS
• Windows
• Windows-container

The change broke all jobs running on Ubuntu Focal: http://build.ros2.org/view/Fci/

geometry2/tf2_py/src/tf2_py.cpp:1059:1: error: cannot convert ‘std::nullptr_t’ to ‘Py_ssize_t’ {aka ‘long int’} in initialization
 1059 | };
      | ^

@ahcorde Please fix asap.