Make pip command configurable via PIP variable in Makefile#12641
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #12641 +/- ##
=======================================
Coverage 98.95% 98.95%
=======================================
Files 131 131
Lines 46476 46476
Branches 2410 2410
=======================================
Hits 45988 45988
Misses 366 366
Partials 122 122
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Merging this PR will not alter performance
Comparing Footnotes
|
Backport to 3.13: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 1aef5d7 on top of patchback/backports/3.13/1aef5d7021e138fa2297f5cc12e2f370c3614c96/pr-12641 Backporting merged PR #12641 into master
🤖 @patchback |
Backport to 3.14: 💚 backport PR created✅ Backport PR branch: Backported as #12642 🤖 @patchback |
… PIP variable in Makefile (#12644)
… PIP variable in Makefile (#12642) Co-authored-by: J. Nick Koston <nick@koston.org>
What do these changes do?
Adds a
PIP ?= python -m pipvariable to the Makefile and threads$(PIP)through every install recipe (.update-pip,.install-cython,.install-deps,.develop,install); downstream CI such as yarl can now runmake .develop PIP="uv pip"to install via uv without us maintaining a parallel.develop-uvtarget.Are there changes in behavior for the user?
No; the default expands to the existing
python -m pipinvocation, so contributors and existing CI see no difference.Is it a substantial burden for the maintainers to support this?
No; it is one variable plus five mechanical substitutions, and the default value preserves current behavior.
Related issue number
Follow-up to aio-libs/yarl#1716, which switched yarl's downstream aiohttp test runner to uv but still falls back to pip inside
make .develop.Checklist
CONTRIBUTORS.txtCHANGES/folderCHANGES/12641.contrib.rst.Drafted with Claude Code (claude-opus-4-7); reviewed by @bdraco.