Skip to content

[PR #12641/1aef5d70 backport][3.13] Make pip command configurable via PIP variable in Makefile#12644

Merged
bdraco merged 2 commits into
3.13from
patchback/backports/3.13/1aef5d7021e138fa2297f5cc12e2f370c3614c96/pr-12641
May 19, 2026
Merged

[PR #12641/1aef5d70 backport][3.13] Make pip command configurable via PIP variable in Makefile#12644
bdraco merged 2 commits into
3.13from
patchback/backports/3.13/1aef5d7021e138fa2297f5cc12e2f370c3614c96/pr-12641

Conversation

@bdraco

@bdraco bdraco commented May 19, 2026

Copy link
Copy Markdown
Member

This is a backport of PR #12641 as merged into master (1aef5d7).

What do these changes do?

Adds a PIP ?= python -m pip variable to the Makefile and threads $(PIP) through every install recipe (.update-pip, .install-cython, .install-deps, .develop, install); downstream CI such as yarl can now run make .develop PIP="uv pip" to install via uv without us maintaining a parallel .develop-uv target.

Are there changes in behavior for the user?

No; the default expands to the existing python -m pip invocation, so contributors and existing CI see no difference.

Is it a substantial burden for the maintainers to support this?

No; it is one variable plus five mechanical substitutions, and the default value preserves current behavior.

Related issue number

Follow-up to aio-libs/yarl#1716, which switched yarl's downstream aiohttp test runner to uv but still falls back to pip inside make .develop.

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
    • N/A, Makefile-only knob with no behavior change at the default.
  • Documentation reflects the changes
    • N/A, internal contributor knob.
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • Already listed.
  • Add a new news fragment into the CHANGES/ folder
    • CHANGES/12641.contrib.rst.

Drafted with Claude Code (claude-opus-4-7); reviewed by @bdraco.

@psf-chronographer psf-chronographer Bot added the bot:chronographer:provided There is a change note present in this PR label May 19, 2026
@bdraco bdraco marked this pull request as ready for review May 19, 2026 02:25
@bdraco bdraco requested review from asvetlov and webknjaz as code owners May 19, 2026 02:25
Comment thread CHANGES/12641.contrib.rst Outdated
@codecov

codecov Bot commented May 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.29%. Comparing base (4ec3ac3) to head (83b32fe).
⚠️ Report is 1 commits behind head on 3.13.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             3.13   #12644      +/-   ##
==========================================
- Coverage   98.29%   98.29%   -0.01%     
==========================================
  Files         128      128              
  Lines       44881    44881              
  Branches     2440     2440              
==========================================
- Hits        44117    44116       -1     
  Misses        589      589              
- Partials      175      176       +1     
Flag Coverage Δ
CI-GHA 98.17% <ø> (-0.01%) ⬇️
OS-Linux 97.93% <ø> (ø)
OS-Windows 95.62% <ø> (-0.01%) ⬇️
OS-macOS 97.19% <ø> (+<0.01%) ⬆️
Py-3.10.11 96.73% <ø> (+<0.01%) ⬆️
Py-3.10.20 97.22% <ø> (ø)
Py-3.11.15 97.39% <ø> (-0.01%) ⬇️
Py-3.11.9 96.92% <ø> (ø)
Py-3.12.10 97.00% <ø> (-0.01%) ⬇️
Py-3.12.13 97.49% <ø> (+<0.01%) ⬆️
Py-3.13.13 97.71% <ø> (-0.02%) ⬇️
Py-3.14.4 96.90% <ø> (ø)
Py-3.14.5 97.41% <ø> (+<0.01%) ⬆️
Py-3.14.5t 96.74% <ø> (+<0.01%) ⬆️
Py-3.9.13 96.61% <ø> (ø)
Py-3.9.25 97.10% <ø> (ø)
Py-pypy3.11.15-7.3.22 96.79% <ø> (ø)
VM-macos 97.19% <ø> (+<0.01%) ⬆️
VM-ubuntu 97.93% <ø> (ø)
VM-windows 95.62% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco enabled auto-merge (squash) May 19, 2026 02:31
@codspeed-hq

codspeed-hq Bot commented May 19, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 59 untouched benchmarks


Comparing patchback/backports/3.13/1aef5d7021e138fa2297f5cc12e2f370c3614c96/pr-12641 (83b32fe) with 3.13 (4ec3ac3)

Open in CodSpeed

@bdraco bdraco merged commit 63ff485 into 3.13 May 19, 2026
41 checks passed
@bdraco bdraco deleted the patchback/backports/3.13/1aef5d7021e138fa2297f5cc12e2f370c3614c96/pr-12641 branch May 19, 2026 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant