Skip to content

[PR #12641/1aef5d70 backport][3.14] Make pip command configurable via PIP variable in Makefile#12642

Merged
bdraco merged 2 commits into
3.14from
patchback/backports/3.14/1aef5d7021e138fa2297f5cc12e2f370c3614c96/pr-12641
May 19, 2026
Merged

[PR #12641/1aef5d70 backport][3.14] Make pip command configurable via PIP variable in Makefile#12642
bdraco merged 2 commits into
3.14from
patchback/backports/3.14/1aef5d7021e138fa2297f5cc12e2f370c3614c96/pr-12641

Conversation

@patchback

@patchback patchback Bot commented May 19, 2026

Copy link
Copy Markdown
Contributor

This is a backport of PR #12641 as merged into master (1aef5d7).

What do these changes do?

Adds a PIP ?= python -m pip variable to the Makefile and threads $(PIP) through every install recipe (.update-pip, .install-cython, .install-deps, .develop, install); downstream CI such as yarl can now run make .develop PIP="uv pip" to install via uv without us maintaining a parallel .develop-uv target.

Are there changes in behavior for the user?

No; the default expands to the existing python -m pip invocation, so contributors and existing CI see no difference.

Is it a substantial burden for the maintainers to support this?

No; it is one variable plus five mechanical substitutions, and the default value preserves current behavior.

Related issue number

Follow-up to aio-libs/yarl#1716, which switched yarl's downstream aiohttp test runner to uv but still falls back to pip inside make .develop.

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
    • N/A, Makefile-only knob with no behavior change at the default.
  • Documentation reflects the changes
    • N/A, internal contributor knob.
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • Already listed.
  • Add a new news fragment into the CHANGES/ folder
    • CHANGES/12641.contrib.rst.

Drafted with Claude Code (claude-opus-4-7); reviewed by @bdraco.

@patchback patchback Bot requested review from asvetlov and webknjaz as code owners May 19, 2026 02:17
@bdraco bdraco enabled auto-merge (squash) May 19, 2026 02:23
@codecov

codecov Bot commented May 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.19%. Comparing base (f54c408) to head (61b6500).
⚠️ Report is 1 commits behind head on 3.14.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.14   #12642   +/-   ##
=======================================
  Coverage   98.19%   98.19%           
=======================================
  Files         135      135           
  Lines       47319    47319           
  Branches     2543     2543           
=======================================
  Hits        46467    46467           
  Misses        673      673           
  Partials      179      179           
Flag Coverage Δ
CI-GHA 98.25% <ø> (-0.01%) ⬇️
OS-Linux 98.01% <ø> (-0.01%) ⬇️
OS-Windows 95.65% <ø> (+<0.01%) ⬆️
OS-macOS 97.19% <ø> (+0.01%) ⬆️
Py-3.10 97.39% <ø> (+<0.01%) ⬆️
Py-3.11 97.67% <ø> (-0.01%) ⬇️
Py-3.12 97.75% <ø> (+<0.01%) ⬆️
Py-3.13 97.72% <ø> (ø)
Py-3.14 97.84% <ø> (+0.01%) ⬆️
Py-3.14t 96.80% <ø> (-0.01%) ⬇️
Py-pypy-3.11 96.66% <ø> (+<0.01%) ⬆️
VM-macos 97.19% <ø> (+0.01%) ⬆️
VM-ubuntu 98.01% <ø> (-0.01%) ⬇️
VM-windows 95.65% <ø> (+<0.01%) ⬆️
cython-coverage 38.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread CHANGES/12641.contrib.rst Outdated
@codspeed-hq

codspeed-hq Bot commented May 19, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 67 untouched benchmarks
⏩ 7 skipped benchmarks1


Comparing patchback/backports/3.14/1aef5d7021e138fa2297f5cc12e2f370c3614c96/pr-12641 (61b6500) with 3.14 (f54c408)

Open in CodSpeed

Footnotes

  1. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@bdraco bdraco merged commit 7978c71 into 3.14 May 19, 2026
40 checks passed
@bdraco bdraco deleted the patchback/backports/3.14/1aef5d7021e138fa2297f5cc12e2f370c3614c96/pr-12641 branch May 19, 2026 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant