chore(sdk/nodejs): migrate linting from ESLint to Biome#4426
Merged
markmandel merged 2 commits intoagones-dev:mainfrom Jan 20, 2026
Merged
chore(sdk/nodejs): migrate linting from ESLint to Biome#4426markmandel merged 2 commits intoagones-dev:mainfrom
markmandel merged 2 commits intoagones-dev:mainfrom
Conversation
Replace ESLint with Biome for linting and formatting the Node.js SDK, using Biome's standard recommended rules. Changes: - Remove eslint and globals dependencies - Add @biomejs/biome with default recommended rules - Update lint script to use biome check --write - Apply Biome formatting (double quotes, consistent spacing) - Prefix unused callback parameters with underscore - Replace forEach with for...of to avoid implicit return - Replace TypeScript 'any' types with 'unknown' Signed-off-by: Sadique Azmi <sadiquemobaraka5@gmail.com>
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
sdks/nodejs/biome.json
Outdated
| @@ -0,0 +1,24 @@ | |||
| { | |||
| "$schema": "https://biomejs.dev/schemas/2.3.11/schema.json", | |||
Collaborator
There was a problem hiding this comment.
It looks like this line is indented with spaces and others with tabs
Contributor
Author
There was a problem hiding this comment.
My bad. I added this from my work machine, and the IDE there has different tab/space rules. I’ll fix it.
Collaborator
|
Everything else looks great |
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
steven-supersolid
approved these changes
Jan 19, 2026
markmandel
approved these changes
Jan 20, 2026
Collaborator
|
/gcbrun |
Collaborator
|
Build Succeeded 🥳 Build Id: d3f3412e-4bc7-431a-80a5-6ade8b92a0e0 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
mnthe
pushed a commit
to mnthe/agones
that referenced
this pull request
Mar 23, 2026
) * chore(sdk/nodejs): migrate linting from ESLint to Biome Replace ESLint with Biome for linting and formatting the Node.js SDK, using Biome's standard recommended rules. Changes: - Remove eslint and globals dependencies - Add @biomejs/biome with default recommended rules - Update lint script to use biome check --write - Apply Biome formatting (double quotes, consistent spacing) - Prefix unused callback parameters with underscore - Replace forEach with for...of to avoid implicit return - Replace TypeScript 'any' types with 'unknown' Signed-off-by: Sadique Azmi <sadiquemobaraka5@gmail.com> * Fix formatting in biome.json --------- Signed-off-by: Sadique Azmi <sadiquemobaraka5@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / Why we need it:
Migrates the Node.js SDK linting from ESLint to Biome, using Biome's standard recommended rules with no custom overrides.
Changes include:
eslintandglobalsdependencies with@biomejs/biomelintscript fromeslint --fixtobiome check --write_forEachwithfor...ofto avoid implicit return valuesanytypes withunknownWhich issue(s) this PR fixes:
Closes #4425
Special notes for your reviewer:
make run-sdk-conformance-test-nodenpm test(78 specs, 0 failures)