chore(sdk/nodejs): update dependencies and migrate to ESLint 9 config#4412
chore(sdk/nodejs): update dependencies and migrate to ESLint 9 config#4412markmandel merged 3 commits intoagones-dev:mainfrom
Conversation
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
|
Build Succeeded 🥳 Build Id: 591f3705-1af3-4bc9-a738-b4ae45bb800d The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
lacroixthomas
left a comment
There was a problem hiding this comment.
LGTM !
But it's been quite some time I've been doing some Node, I've been looking a bit on the changes with ESLint 9 etc. it's looking all good, but a second approval would be great though 😄
sdks/nodejs/package.json
Outdated
| "dependencies": { | ||
| "@grpc/grpc-js": "1.10.9", | ||
| "google-protobuf": "3.21.2" | ||
| "@grpc/grpc-js": "^1.14.3", |
There was a problem hiding this comment.
It may be safer to pin these versions, i.e. remove the ^
This way if there is a later vulnerability introduced in a dependency then it won't bubble up through the agones package
We leave dev dependencies unpinned as these will only be installed on the developer machine
| ...globals.jasmine | ||
| } | ||
| }, | ||
| rules: { |
There was a problem hiding this comment.
This looks good but apparently these stylistic rules are no longer recommended and may not work. If npm run lint works then all is good for now
I recommend moving to biome as we can just use the standard rules with no overrides with the consequence quotes will change to double but this could be a separate task
Upgrade Node.js SDK dependencies to latest versions and migrate ESLint configuration from legacy .eslintrc.json to the new flat config format required by ESLint 9.
32313e3 to
3db497e
Compare
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
|
Build Succeeded 🥳 Build Id: 72c1d5b8-52a3-4f4b-8052-e76097441f01 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
…agones-dev#4412) * chore(sdk/nodejs): update dependencies and migrate to ESLint 9 config Upgrade Node.js SDK dependencies to latest versions and migrate ESLint configuration from legacy .eslintrc.json to the new flat config format required by ESLint 9. * Review updates.
What type of PR is this?
/kind cleanup
What this PR does / Why we need it:
Upgrade Node.js SDK dependencies to latest versions and migrate ESLint configuration from legacy .eslintrc.json to the new flat config format required by ESLint 9.
Which issue(s) this PR fixes:
This was mostly just to clean up the dependabot PRs that have been there for ages - hopefully I did right by NodeJS code 😄
Special notes for your reviewer:
@steven-supersolid did I do okay? 😄 (or anyone else with Node experience).