-
Notifications
You must be signed in to change notification settings - Fork 898
Move Node SDK linting to biome #4425
Copy link
Copy link
Closed
Labels
good first issueThese are great first issues. If you are looking for a place to start, start here!These are great first issues. If you are looking for a place to start, start here!help wantedWe would love help on these issues. Please come help us!We would love help on these issues. Please come help us!kind/cleanupRefactoring code, fixing up documentation, etcRefactoring code, fixing up documentation, etc
Description
Move Node linting to "biome" - https://www.npmjs.com/package/@biomejs/biome
This looks good but apparently these stylistic rules are no longer recommended and may not work. If
npm run lintworks then all is good for nowI recommend moving to biome as we can just use the standard rules with no overrides with the consequence quotes will change to double but this could be a separate task
Originally posted by @steven-supersolid in #4412
So there may be some tweaks to the SDk as well to align with the new style guides.
To test if the changes work as expected locally: make run-sdk-conformance-test-node is what you are looking for.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
good first issueThese are great first issues. If you are looking for a place to start, start here!These are great first issues. If you are looking for a place to start, start here!help wantedWe would love help on these issues. Please come help us!We would love help on these issues. Please come help us!kind/cleanupRefactoring code, fixing up documentation, etcRefactoring code, fixing up documentation, etc