Skip to content

cleanup(ci): Remove 403 link for Win 10 and minikube#4349

Merged
markmandel merged 2 commits intoagones-dev:mainfrom
markmandel:ci/fix-win-10-minikube
Nov 26, 2025
Merged

cleanup(ci): Remove 403 link for Win 10 and minikube#4349
markmandel merged 2 commits intoagones-dev:mainfrom
markmandel:ci/fix-win-10-minikube

Conversation

@markmandel
Copy link
Copy Markdown
Collaborator

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

This link was 403'ing on CI, and Windows 10 is EOL, so I removed it entirely.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

Should unblock the tests section of CI.

This link was 403'ing on CI, and Windows 10 is EOL, so I removed it
entirely.
@markmandel markmandel added kind/documentation Documentation for Agones area/tests Unit tests, e2e tests, anything to make sure things don't break labels Nov 25, 2025
@github-actions github-actions bot added kind/cleanup Refactoring code, fixing up documentation, etc size/XS labels Nov 25, 2025
Copy link
Copy Markdown
Collaborator

@lacroixthomas lacroixthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's annoying that it sometimes fail the whole build pipeline, when you create a PR and the build fails because of an invalid link that you didn't touch 😅

@lacroixthomas
Copy link
Copy Markdown
Collaborator

But I dont have other solutions to ensure the links are still valid, or maybe having some kind of warning or something similar for us to be aware of it and create an issue about it ?

Not sure how critical it is for us, for it to fail the whole build ?

@markmandel
Copy link
Copy Markdown
Collaborator Author

Does mean you fix it right away 😆

@agones-bot
Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: fd5b2023-0a1d-467d-bcd3-749c7d3778dc

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel markmandel enabled auto-merge (squash) November 26, 2025 00:03
@agones-bot
Copy link
Copy Markdown
Collaborator

Build Succeeded 🥳

Build Id: 23aabb25-0f05-40d1-86a0-80236adebf29

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4349/head:pr_4349 && git checkout pr_4349
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.54.0-dev-cb080f8

@markmandel markmandel merged commit 7fbabf7 into agones-dev:main Nov 26, 2025
4 checks passed
@markmandel markmandel deleted the ci/fix-win-10-minikube branch November 26, 2025 01:08
Sivasankaran25 pushed a commit to Sivasankaran25/agones that referenced this pull request Nov 26, 2025
* cleanup(ci): Remove 403 link for Win 10 and minikube

This link was 403'ing on CI, and Windows 10 is EOL, so I removed it
entirely.
* Also skip supersolid
igooch added a commit that referenced this pull request Dec 2, 2025
* Graduate AutopilotPassthroughPort to Stable

* remove autopilot value in gke test

* cleanup(ci): Remove 403 link for Win 10 and minikube (#4349)

* cleanup(ci): Remove 403 link for Win 10 and minikube

This link was 403'ing on CI, and Windows 10 is EOL, so I removed it
entirely.
* Also skip supersolid

* remove assignees from update dependencies github issue creation (#4327)

* remove comments lines in gke

* fix review changes

---------

Co-authored-by: Mark Mandel <mark@compoundtheory.com>
Co-authored-by: igooch <igooch@google.com>
mnthe pushed a commit to mnthe/agones that referenced this pull request Mar 23, 2026
* cleanup(ci): Remove 403 link for Win 10 and minikube

This link was 403'ing on CI, and Windows 10 is EOL, so I removed it
entirely.
* Also skip supersolid
mnthe pushed a commit to mnthe/agones that referenced this pull request Mar 23, 2026
* Graduate AutopilotPassthroughPort to Stable

* remove autopilot value in gke test

* cleanup(ci): Remove 403 link for Win 10 and minikube (agones-dev#4349)

* cleanup(ci): Remove 403 link for Win 10 and minikube

This link was 403'ing on CI, and Windows 10 is EOL, so I removed it
entirely.
* Also skip supersolid

* remove assignees from update dependencies github issue creation (agones-dev#4327)

* remove comments lines in gke

* fix review changes

---------

Co-authored-by: Mark Mandel <mark@compoundtheory.com>
Co-authored-by: igooch <igooch@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/tests Unit tests, e2e tests, anything to make sure things don't break kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants