Graduate AutopilotPassthroughPort to Stable#4335
Conversation
|
Build Succeeded 🥳 Build Id: 7eb051fd-e773-4ebf-af56-ad6a95dd6f39 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
|
Build Failed 😭 Build Id: d9beb6ac-3fe6-43ba-b324-43865bd0679d Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
/gcbrun |
|
Build Failed 😭 Build Id: d0ee8e6e-0051-4484-a21e-6a51586e0984 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
/gcbrun |
|
Build Succeeded 🥳 Build Id: e2cf0dd8-709e-45bc-bdba-4b0f0c10adc8 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
|
Build Succeeded 🥳 Build Id: 8f5b705d-c979-4332-91cb-d7aecc11b53d The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
pkg/cloudproduct/gke/gke_test.go
Outdated
There was a problem hiding this comment.
Looks like there's another reference here that should be removed.
|
Build Succeeded 🥳 Build Id: b018f3d6-09b5-46e5-9221-894a81d758bf The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
* cleanup(ci): Remove 403 link for Win 10 and minikube This link was 403'ing on CI, and Windows 10 is EOL, so I removed it entirely. * Also skip supersolid
|
Build Succeeded 🥳 Build Id: 5d98d187-1480-4bbd-895c-ba05781f5e74 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
vicentefb
left a comment
There was a problem hiding this comment.
lgtm i think there's this comment left to be addressed https://github.com/googleforgames/agones/pull/4335/files/afb62d91f505c451fae767846280adbc05f6ecc2#r2558746760
|
Build Failed 😭 Build Id: 3292d1ea-7a92-4dbc-a2f0-80544a2d66a2 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
/gcbrun |
|
Build Succeeded 🥳 Build Id: 4628632c-028a-4ef7-94d5-e323e40aeadb The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
|
Build Failed 😭 Build Id: 527333e4-afb9-452d-90fa-33154cd7b6de Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
/gcbrun |
|
Build Succeeded 🥳 Build Id: 3e1421fe-6014-4af7-9b09-f87ed33da3bf The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
|
Build Succeeded 🥳 Build Id: 055dc7bf-9d23-43a9-9c24-e32b0d2cf23f The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
* Graduate AutopilotPassthroughPort to Stable * remove autopilot value in gke test * cleanup(ci): Remove 403 link for Win 10 and minikube (agones-dev#4349) * cleanup(ci): Remove 403 link for Win 10 and minikube This link was 403'ing on CI, and Windows 10 is EOL, so I removed it entirely. * Also skip supersolid * remove assignees from update dependencies github issue creation (agones-dev#4327) * remove comments lines in gke * fix review changes --------- Co-authored-by: Mark Mandel <mark@compoundtheory.com> Co-authored-by: igooch <igooch@google.com>
What type of PR is this?
/kind feature
What this PR does / Why we need it:
Which issue(s) this PR fixes:
Closes #4322
Special notes for your reviewer: