Skip to content

Remove assignees from update dependencies github issue creation#4327

Merged
igooch merged 4 commits intoagones-dev:mainfrom
igooch:update-dependencies
Nov 26, 2025
Merged

Remove assignees from update dependencies github issue creation#4327
igooch merged 4 commits intoagones-dev:mainfrom
igooch:update-dependencies

Conversation

@igooch
Copy link
Copy Markdown
Collaborator

@igooch igooch commented Nov 7, 2025

What type of PR is this?

/kind cleanup

What this PR does / Why we need it:

This PR removes the assignees from the "update dependencies" automated github issue creation. If an assignee's GitHub username become inactive the github action will fail, and the issue is not created. It is preferable to create the issue without assignees, and manually assign maintainers rather than have the automatic issue creation fail.

Which issue(s) this PR fixes:

NA

Special notes for your reviewer:

@igooch igooch requested a review from peterzhongyi November 7, 2025 18:50
@github-actions github-actions bot added kind/cleanup Refactoring code, fixing up documentation, etc size/XS labels Nov 7, 2025
@agones-bot
Copy link
Copy Markdown
Collaborator

Build Succeeded 🥳

Build Id: 3ba09cbe-1942-49c5-9b44-82919d005322

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4327/head:pr_4327 && git checkout pr_4327
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.54.0-dev-acf26c9

@igooch igooch requested a review from vicentefb November 24, 2025 23:13
@igooch igooch enabled auto-merge (squash) November 24, 2025 23:30
@agones-bot
Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: b5c7c1ad-6d68-4366-8831-1ff3ca528029

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: 251e072e-3a65-4ec9-be42-5851dcc3c928

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch
Copy link
Copy Markdown
Collaborator Author

igooch commented Nov 25, 2025

/gcbrun

@agones-bot
Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: 023bde2a-baf6-4a87-b6f0-d1f1216114e1

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Copy Markdown
Collaborator

/gcbrun

@agones-bot
Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: 7cb85e8e-0ddb-4f41-9197-affb2b6711f2

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Copy Markdown
Collaborator

	--set agones.allocator.service.loadBalancerIP=107.167.186.23 \
	--set agones.metrics.serviceMonitor.enabled=false \
	 \
	agones /go/src/agones.dev/agones/install/helm/agones/
Release "agones" does not exist. Installing it now.
Error: release agones failed, and has been uninstalled due to atomic being set: failed to refresh resource information: services "agones-allocator" not found
make: *** [Makefile:450: install] Error 1

occasionally this happens, it's rather odd.

/gcbrun

@agones-bot
Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: 3804ca36-dd9c-45bd-ae4e-4648631a2780

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Copy Markdown
Collaborator

/gcbrun

@agones-bot
Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: b45c6109-2f10-487c-830e-eeb089ead1c8

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Copy Markdown
Collaborator

I1125 19:35:39.344873      84 warnings.go:110] "Warning: autopilot-default-resources-mutator:Autopilot updated Deployment agones-system/agones-ping: defaulted unspecified 'cpu' resource for containers [agones-ping] (see http://g.co/gke/autopilot-defaults)."
I1125 19:35:39.753008      84 warnings.go:110] "Warning: autopilot-default-resources-mutator:Autopilot updated Deployment agones-system/agones-allocator: defaulted unspecified 'cpu' resource for containers [agones-allocator] (see http://g.co/gke/autopilot-defaults)."
I1125 19:35:40.552292      84 warnings.go:110] "Warning: AdmissionWebhookController: mutated namespaceselector of the webhooks to enforce GKE Autopilot policies."
I1125 19:35:40.936474      84 warnings.go:110] "Warning: AdmissionWebhookController: mutated namespaceselector of the webhooks to enforce GKE Autopilot policies."
I1125 19:45:52.611342      84 warnings.go:110] "Warning: autopilot-default-resources-mutator:Autopilot updated Job agones-system/agones-delete-agones-resources: defaulted unspecified 'cpu' resource for containers [pre-delete-delete-agones-resources] (see http://g.co/gke/autopilot-defaults)."
Error: release agones failed, and has been uninstalled due to atomic being set: context deadline exceeded
make: *** [Makefile:450: install] Error 1

Something weird's been going on.

@markmandel
Copy link
Copy Markdown
Collaborator

/gcbrun

@agones-bot
Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: ae639dd1-2167-45b6-b5c5-884028818e94

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Copy Markdown
Collaborator

========================================================================
site/docs/installation/creating-cluster/minikube/index.html
  Non-OK status: 403 --- site/docs/installation/creating-cluster/minikube/index.html --> https://blog.thepolyglotprogrammer.com/setting-up-kubernetes-on-wsl-to-work-with-minikube-on-windows-10-90dac3c72fa1
========================================================================

sigh

@agones-bot
Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: 33dc0358-d5d3-4c01-b36c-1edca91c2a88

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Copy Markdown
Collaborator

New flake in unit tests:

--- FAIL: TestMultiClusterAllocationFromLocal (1.03s)
    --- FAIL: TestMultiClusterAllocationFromLocal/Handle_allocation_request_locally (1.03s)
        controller_test.go:264: 
            	Error Trace:	/go/src/agones.dev/agones/pkg/gameserverallocations/controller_test.go:264
            	Error:      	Received unexpected error:
            	            	json: cannot unmarshal string into Go struct field GameServerAllocation.status of type v1.GameServerAllocationStatus
            	Test:       	TestMultiClusterAllocationFromLocal/Handle_allocation_request_locally
panic: runtime error: index out of range [0] with length 0 [recovered]
	panic: runtime error: index out of range [0] with length 0

/gcbrun

@agones-bot
Copy link
Copy Markdown
Collaborator

Build Succeeded 🥳

Build Id: d9e86a99-2956-4b34-9681-441574a18369

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4327/head:pr_4327 && git checkout pr_4327
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.54.0-dev-5ed0e87

@igooch igooch merged commit 803d5ff into agones-dev:main Nov 26, 2025
4 checks passed
Sivasankaran25 pushed a commit to Sivasankaran25/agones that referenced this pull request Nov 26, 2025
igooch added a commit that referenced this pull request Dec 2, 2025
* Graduate AutopilotPassthroughPort to Stable

* remove autopilot value in gke test

* cleanup(ci): Remove 403 link for Win 10 and minikube (#4349)

* cleanup(ci): Remove 403 link for Win 10 and minikube

This link was 403'ing on CI, and Windows 10 is EOL, so I removed it
entirely.
* Also skip supersolid

* remove assignees from update dependencies github issue creation (#4327)

* remove comments lines in gke

* fix review changes

---------

Co-authored-by: Mark Mandel <mark@compoundtheory.com>
Co-authored-by: igooch <igooch@google.com>
mnthe pushed a commit to mnthe/agones that referenced this pull request Mar 23, 2026
* Graduate AutopilotPassthroughPort to Stable

* remove autopilot value in gke test

* cleanup(ci): Remove 403 link for Win 10 and minikube (agones-dev#4349)

* cleanup(ci): Remove 403 link for Win 10 and minikube

This link was 403'ing on CI, and Windows 10 is EOL, so I removed it
entirely.
* Also skip supersolid

* remove assignees from update dependencies github issue creation (agones-dev#4327)

* remove comments lines in gke

* fix review changes

---------

Co-authored-by: Mark Mandel <mark@compoundtheory.com>
Co-authored-by: igooch <igooch@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/cleanup Refactoring code, fixing up documentation, etc size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants