cleanup(core): delete orphan RigctlServer and RigctlPty files#3380
Merged
Conversation
…sdr#3142) PR aethersdr#3131 replaced the old CAT server hierarchy with CatPort + SmartCatProtocol + SmartCatSession. The legacy files were unwired but not deleted: - src/core/RigctlServer.cpp / .h (no CMake entry, no includes) - src/core/RigctlPty.cpp / .h (still listed in CMakeLists.txt:458) Remove all four files and drop RigctlPty.cpp from CORE_SOURCES. GHSA comment-only references retained; live-code grep confirms zero users remain. Closes aethersdr#3142 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Clean surgical deletion — verified against the live tree:
- No
#include "RigctlServer.h"/#include "RigctlPty.h"from any live source. - No
new RigctlServer(...)/new RigctlPty(...)instantiations or other symbol references. CMakeLists.txthad exactly one remaining build entry (src/core/RigctlPty.cppat line 525) — correctly removed.RigctlServer.cppwas already absent fromCORE_SOURCES, consistent with the "unwired by #3131 but not deleted" framing.- Surviving textual references (CatPort.h/.cpp, RadioConnection.cpp, WanConnection.cpp, SmartLinkClient.cpp, DxClusterClient.cpp, RigctlProtocol.cpp, MainWindow.cpp, CHANGELOG, ROADMAP) are all narrative comments citing GHSA-7w4w-wfqm-wh93 / GHSA-qxhr-cwrc-pvrm — preserving these is the right call; they document the rationale for the hardening that CatPort now carries.
Out-of-scope check: none. Five files, all directly tied to the dead-code removal.
Thanks for picking up the #3142 loose end, @K5PTB — nice clean follow-up to the #3131 consolidation.
🤖 aethersdr-agent · cost: $16.3737 · model: claude-opus-4-7
jensenpat
approved these changes
Jun 5, 2026
jensenpat
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed: verified all four files are genuinely orphaned. RigctlServer.cpp was not in the build at all; RigctlPty.cpp was the last build reference and is correctly dropped from CORE_SOURCES. No live #include of either header remains anywhere in src/ — only GHSA/comment citations, which are intentionally retained. The still-used RigctlProtocol.cpp (consumed by CatPort) stays. CI green across build/macOS/Windows/CodeQL. Clean dead-code removal. LGTM.
G6PWY-Chris
pushed a commit
to G6PWY-Chris/AetherSDR
that referenced
this pull request
Jun 22, 2026
…sdr#3380) ## Summary - Removes `src/core/RigctlServer.cpp/.h` and `src/core/RigctlPty.cpp/.h` — all four were unwired by PR aethersdr#3131 but not deleted - Drops `src/core/RigctlPty.cpp` from `CORE_SOURCES` in `CMakeLists.txt` (the only remaining build reference) - Live-code grep confirms zero includes or symbol references remain; GHSA comment citations retained as-is ## Test plan - [x] `cmake --build` clean with `--target all` (RelWithDebInfo, macOS M2) - [x] Smoke test: AetherSDR launches, rigctld CAT control functional via CatPort Closes aethersdr#3142 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/core/RigctlServer.cpp/.handsrc/core/RigctlPty.cpp/.h— all four were unwired by PR feat(smartcat): SmartCAT TCP server — TS-2000 and FlexCAT dialects #3131 but not deletedsrc/core/RigctlPty.cppfromCORE_SOURCESinCMakeLists.txt(the only remaining build reference)Test plan
cmake --buildclean with--target all(RelWithDebInfo, macOS M2)Closes #3142
🤖 Generated with Claude Code