Background

PR #3131 (@K5PTB's SmartCAT server) replaced the old CAT server hierarchy with a unified CatPort + SmartCatProtocol + SmartCatSession design.

The legacy files were unwired but not deleted:

RigctlPty.cpp builds but its symbols have no users — pure dead weight in the link.

Verification done

$ grep -rn 'RigctlServer\|RigctlPty' src/ tests/ | grep -v 'RigctlServer\.\|RigctlPty\.'
# only historical comments remain (SmartLinkClient, WanConnection, RadioConnection,
# DxClusterClient, RigctlProtocol, CatPort) — no live code references

$ grep -rn '#include.*\(RigctlServer\|RigctlPty\)' src/ tests/ | grep -v 'RigctlServer\.\|RigctlPty\.'
# zero hits

The change

1. git rm src/core/RigctlServer.cpp src/core/RigctlServer.h
2. git rm src/core/RigctlPty.cpp src/core/RigctlPty.h
3. Remove src/core/RigctlPty.cpp from the CORE_SOURCES list in CMakeLists.txt:458
4. Optionally: sweep the remaining comment-only references (mostly GHSA citations) to update wording from "RigctlServer" → "CatPort" where the citation is about the architectural pattern, not the historical bug. Leave GHSA references intact since they cite the original incident.

Acceptance

• Files removed from disk
• CMakeLists.txt:458 line gone
• cmake --build succeeds with --target all (catches any test target that referenced the orphans)
• Smoke test: launch AetherSDR, confirm CAT controls still work via CatPort

Why now

PR #3131 acknowledged the cleanup as a follow-up. Splitting it out keeps that PR's diff focused on the new functionality.

73, Jeremy KK7GWY & Claude (AI dev partner)