Files were superseded by CatPort (per CatPort.h:25) and were never
added to CMakeLists.txt.  SmartCatServer.cpp:74 also called a 5-arg
SmartCatSession ctor that no longer exists (current sig has a
flexExtensions param between vfoB and parent), so the files would not
compile if anything linked them.

Flagged by aethersdr-agent review of aethersdr#3131.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Track m_pttAssertedByMe in SmartCatProtocol — set in cmdTX(), cleared
in cmdRX(). SmartCatSession::onDisconnected() and ~SmartCatSession()
both call releasePtt(), which forces setTransmit(false, PttSource::Dax)
only if this protocol instance was the one that keyed the radio.

Guards against leaving the radio transmitting after an abrupt client
drop (crash, network blip, SIGKILL). Does not unconditionally force RX,
so PTT from the front panel, footswitch, or another CAT client is
unaffected.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

CatPort::onPtyData() calls ::write() on a non-blocking fd. Previously
the return value was silently discarded; now a qCWarning is emitted on
negative return so a full kernel buffer is diagnosable in the log.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Anticipated by the CAT-server PR (#3131): K5PTB had to hardcode
`#006040` for the CAT-active :checked button background because the
canonical taxonomy had `color.background.tx` (warm orange — TX
indicator) but no green sibling for the "success / active" state.

Adds the missing token in both bundled themes and the seedBuiltinDefaults
fallback so #3131 (and any future widget that needs a green-active
background tint) can use `{{color.background.success}}` instead of
hardcoding hex.

Values picked to match the existing accent-tier conventions:

  default-dark.json   → #006040 (matches K5PTB's hardcode + the
                        existing dim color.accent.success entry)
  default-light.json  → #c8e8d0 (pale green, light enough that dark
                        text reads on it — mirrors how background.tx
                        is a warm light cream in the light theme)
  seedBuiltinDefaults → #006040 (matches the dark theme so the seed
                        fallback path doesn't regress active widgets
                        if the JSON load somehow fails)

A follow-up tool-pass (tools/migrate_colours.py) can sweep
CatPopoutWindow.cpp and CatControlApplet.cpp once #3131 lands to
canonicalize the rest of the hardcoded styles in that PR (~8 more
hex literals, all already-canonical token matches).

73, Jeremy KK7GWY & Claude (AI dev partner)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

## Summary

- Removes `src/core/RigctlServer.cpp/.h` and `src/core/RigctlPty.cpp/.h`
— all four were unwired by PR #3131 but not deleted
- Drops `src/core/RigctlPty.cpp` from `CORE_SOURCES` in `CMakeLists.txt`
(the only remaining build reference)
- Live-code grep confirms zero includes or symbol references remain;
GHSA comment citations retained as-is

## Test plan

- [x] `cmake --build` clean with `--target all` (RelWithDebInfo, macOS
M2)
- [x] Smoke test: AetherSDR launches, rigctld CAT control functional via
CatPort

Closes #3142

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

…ethersdr#3131)

## CAT Protocol Coverage

- Full Kenwood TS-2000 command set, referencing the manual appendix,
except commands not applicable to a FlexRadio
- Full FlexCAT command set per SmartCAT User Guide v4.1.5, with the
exception of ZZPA/ZZPE (panadapter data streaming — out of scope for a
CAT server)
- Two TCP ports by default: 4532 (rigctld) and 5001 (FlexCAT). Up to 6
more ports can be configured/enabled; each port has a companion PTY that
accepts the same commands and responds identically. PTY paths are shown
in the pop-out applet and can be copied to the clipboard with a
right-click — handy when configuring external apps.

## Why CAT in addition to rigctld

Some external apps do not support rigctld, but expect to send TS-2000
CAT commands, with extensions by FlexRadio. AetherSDR now speaks both
protocols, giving operators the flexibility to use whichever their
software requires — setups that currently use SmartCAT can work directly
with AetherSDR without change. TCI is preferred, but this supports both
legacy apps and legacy hams.

## CAT applet redesign

Inspired by SmartSDR for macOS. The space-consuming configuration only
appears when popped out, avoiding clutter of the right panel.

## Test suites

- **`CAT_TS-2000_test`**: 15 sections, 103 checks (92 always-on + 11
PTT/CW gated)
- **`CAT_Flex_test`**: 16 sections, 129 checks (105 always-on + 24
PTT/CW gated)

PTT and CW keyer tests are **skipped by default** to avoid unintended
transmissions. Enable with `--ptt` and `--cw` when a radio is connected
and the operator is ready to transmit.

A firmware TX race was noted during CW testing: the radio briefly
reports TX=0 via CAT while the PA is still hot after CW completes.
Safety watches are added to the test suite; documented as known hardware
behaviour.

## Integration testing

Tested against real hardware (FlexRadio 6500, firmware 4.2.18). Primary
platform: macOS. Also tested on Raspberry Pi 5 / Raspberry Pi OS Trixie.

| App | Connection | Result |
|---|---|---|
| fldigi | TCP + PTY | ✓ |
| WSJT-X | TCP + PTY | ✓ |
| MacLoggerDX | PTY (TS-2000 only) | ✓ |
| N1MM+ | TCP | ✓ (CAT sync; CW keying not possible — see below) |

### N1MM CW keying — known limitation

N1MM keys CW by toggling RTS/DTR on a real serial COM port. Virtual
serial ports (PTYs) are not exposed as COM ports in Windows, so RTS/DTR
keying cannot reach AetherSDR. No workaround exists without a
WinKeyer-compatible keyer emulator. Documented here so operators don't
waste time chasing it.

## Security

Applied the PTY symlink fix (same pattern as GHSA-qxhr-cwrc-pvrm, aethersdr#3027)
to `CatPort`: per-user symlink directories, atomic rename instead of
unlink+symlink.

## Code quality

**UAF audit:** `SmartCatProtocol` and the new `RigctlProtocol` additions
are both clean — no `[this]` captures in queued lambdas; all dispatch is
synchronous on the main thread.

**ThemeManager:** `CatControlApplet` was included in the Phase 2 mass
migration (aethersdr#3102). Because this branch replaces the entire applet, that
migration did not carry forward. We applied
`ThemeManager::applyStyleSheet()` throughout — both the docked panel and
the pop-out — so all widgets auto-restyle on `themeChanged`, consistent
with the rest of the codebase. One intentional hardcode remains: the
`:checked` background `#006040` (CAT active state). There is no
`color.background.success` token analogous to `color.background.tx`;
adding one would complete the conversion and is worth proposing as a
follow-up.

Closes aethersdr#2962

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

…sdr#3380)

## Summary

- Removes `src/core/RigctlServer.cpp/.h` and `src/core/RigctlPty.cpp/.h`
— all four were unwired by PR aethersdr#3131 but not deleted
- Drops `src/core/RigctlPty.cpp` from `CORE_SOURCES` in `CMakeLists.txt`
(the only remaining build reference)
- Live-code grep confirms zero includes or symbol references remain;
GHSA comment citations retained as-is

## Test plan

- [x] `cmake --build` clean with `--target all` (RelWithDebInfo, macOS
M2)
- [x] Smoke test: AetherSDR launches, rigctld CAT control functional via
CatPort

Closes aethersdr#3142

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>