Fix missing HAVE_SERIALPORT guard on m_flexCoalesceTimer (#1606 partial)#1812
Merged
Merged
Conversation
…thersdr#1606 partial) Upstream PR aethersdr#1606 guarded m_hidCoalesceTimer behind HAVE_HIDAPI but left m_flexCoalesceTimer unguarded. Wrap it in HAVE_SERIALPORT to match the header declaration and fix Windows builds without serial port support. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Looks good. Clean, minimal fix.
Verified:
m_flexCoalesceTimeris declared inside#ifdef HAVE_SERIALPORTinMainWindow.h:214-220— the unguarded reference at line 5692 is indeed a build break withoutQt6::SerialPort.- All other usages of
m_flexCoalesceTimer(lines 1804–1849) are already inside theHAVE_SERIALPORTblock — this was the only stray reference. - The
bool activeTuning = false+ conditional OR pattern matches the existingHAVE_HIDAPIguard style on the line below, keeping things consistent. - Single file changed, tightly scoped to the stated issue — nothing outside the PR's scope.
No issues found. Thanks for catching this @NF0T, and for the clear before/after in the PR description.
ten9876
approved these changes
Apr 21, 2026
ten9876
left a comment
Collaborator
There was a problem hiding this comment.
LGTM — matches the HAVE_HIDAPI guard pattern on the line below. Clean fix for the Windows build break.
6 tasks
ten9876
added a commit
that referenced
this pull request
Apr 22, 2026
) Cuts a community-contribution-heavy point release. Eight community PRs landed plus three AetherClaude crash fixes. Highlights: Community: - Fix RADE RX not decoding on Windows (#1820, NF0T) - Clamp stale DAX RX backlog on macOS — fixes +1.5s FT8 DT bias (#1822, jensenpat) - Fix TCI DAX resampler crosstalk between slices (#1815, Chaosuk97) - Fix RX applet pan slider with NR active (#1799, Chaosuk97) - Fix TCI RX gain default 1.0 → 0.5 to match applet (#1811, NF0T) - Fix HAVE_SERIALPORT guard (#1812, NF0T) - Seamless ADIF logbook auto-reload (#1801, Chaosuk97) - RAC Canada band-plan corrections (#1817, VE3NEM) AetherClaude crash fixes: - Applet reorder with floating containers (#1745 → #1746) - Lazy-build RadioSetupDialog tabs, dodges Wayland FFmpeg/VDPAU crash (#1776 → #1777) - PanAdapter float-freeze — show-after-reset + direct reparent (#1668 → #1669) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #1606 guarded
m_hidCoalesceTimerbehind#ifdef HAVE_HIDAPIbut leftm_flexCoalesceTimerunguarded on the line immediately above.m_flexCoalesceTimeris declared inside#ifdef HAVE_SERIALPORTinMainWindow.h(line 217), so the unguarded reference inMainWindow.cppbreaks any build whereHAVE_SERIALPORTis not defined — specifically Windows withoutQt6::SerialPortinstalled.Before (broken):
After:
This was flagged in a comment on #1606 at the time of merge.
Test plan
Qt6::SerialPort— previously failed with'm_flexCoalesceTimer' was not declared in this scope, now compiles clean🤖 Generated with Claude Code