Fix crash when reordering applets with floating containers (#1745)#1746
Merged
Conversation
Skip floating (popped-out) containers in dropIndexFromY(), dragMoveEvent indicator positioning, and rebuildStackOrder() to prevent QWidget::mapTo() crash when the floating widget has no common ancestor with the scroll area. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ten9876
approved these changes
Apr 22, 2026
ten9876
left a comment
Collaborator
There was a problem hiding this comment.
Verified ContainerWidget::isFloating() exists. qobject_cast approach is safe for non-container entries. Pattern applied consistently at all 3 crash sites (dragMoveEvent, rebuildStackOrder, dropIndexFromY). Scope is correctly limited to the crash — TXDSP ID mismatch filed as follow-up #1836. LGTM.
6 tasks
ten9876
added a commit
that referenced
this pull request
Apr 22, 2026
) Cuts a community-contribution-heavy point release. Eight community PRs landed plus three AetherClaude crash fixes. Highlights: Community: - Fix RADE RX not decoding on Windows (#1820, NF0T) - Clamp stale DAX RX backlog on macOS — fixes +1.5s FT8 DT bias (#1822, jensenpat) - Fix TCI DAX resampler crosstalk between slices (#1815, Chaosuk97) - Fix RX applet pan slider with NR active (#1799, Chaosuk97) - Fix TCI RX gain default 1.0 → 0.5 to match applet (#1811, NF0T) - Fix HAVE_SERIALPORT guard (#1812, NF0T) - Seamless ADIF logbook auto-reload (#1801, Chaosuk97) - RAC Canada band-plan corrections (#1817, VE3NEM) AetherClaude crash fixes: - Applet reorder with floating containers (#1745 → #1746) - Lazy-build RadioSetupDialog tabs, dodges Wayland FFmpeg/VDPAU crash (#1776 → #1777) - PanAdapter float-freeze — show-after-reset + direct reparent (#1668 → #1669) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1745
What was changed
Fix crash when reordering applets with floating containers (#1745)
Files modified
src/gui/AppletPanel.cppGenerated by AetherClaude (automated agent for AetherSDR)