Added upstream integration tests for configOverrides feature#413
Merged
addb merged 10 commits intoadobe:feature/datastreamConfigOverridefrom Oct 11, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## feature/datastreamConfigOverride #413 +/- ##
=================================================================
Coverage 96.76% 96.76%
=================================================================
Files 27 27
Lines 1729 1729
=================================================================
Hits 1673 1673
Misses 56 56 |
emdobrin
reviewed
Sep 29, 2023
emdobrin
reviewed
Oct 3, 2023
…ase and TestHelpers. Refactored some helper code to make it extensible and reusable.
timkimadobe
reviewed
Oct 3, 2023
timkimadobe
approved these changes
Oct 4, 2023
emdobrin
reviewed
Oct 5, 2023
Comment on lines
+60
to
+66
| // Set Edge location hint value if one is set for the test target | ||
| if edgeLocationHint != nil { | ||
| print("Setting Edge location hint to: \(String(describing: edgeLocationHint?.rawValue))") | ||
| Edge.setLocationHint(edgeLocationHint?.rawValue) | ||
| } else { | ||
| print("No preset Edge location hint is being used for this test.") | ||
| } |
Contributor
There was a problem hiding this comment.
this can be an EdgeHelper too
Contributor
Author
There was a problem hiding this comment.
What are you thinking when you say as a helper? I have pushed some updates, but I think I might have not extracted this lcoationHint and edgeEnvironment as per your thinking. Let me know if I missed something in the updates.
Contributor
There was a problem hiding this comment.
I was referring to L56 -> L62 which can be extracted in TestBase+EdgeHelpers in a simple func setInitialLocationHint(edgeLocationHint) so all tests can use it as is and also save some lines
Contributor
Author
There was a problem hiding this comment.
I did not move that since we don't register Edge extension in the TestBase.
emdobrin
approved these changes
Oct 9, 2023
Contributor
emdobrin
left a comment
There was a problem hiding this comment.
Left some responses below, looks great
Comment on lines
+60
to
+66
| // Set Edge location hint value if one is set for the test target | ||
| if edgeLocationHint != nil { | ||
| print("Setting Edge location hint to: \(String(describing: edgeLocationHint?.rawValue))") | ||
| Edge.setLocationHint(edgeLocationHint?.rawValue) | ||
| } else { | ||
| print("No preset Edge location hint is being used for this test.") | ||
| } |
Contributor
There was a problem hiding this comment.
I was referring to L56 -> L62 which can be extracted in TestBase+EdgeHelpers in a simple func setInitialLocationHint(edgeLocationHint) so all tests can use it as is and also save some lines
addb
added a commit
that referenced
this pull request
Oct 24, 2023
* Update Experience Event class for Datastream Config Override Feature (#397) * Modify Experience event class to add datastreamIdOverride and datastreamConfigOverride fields. * Updates based on reviews * format fixes * Review updates * Add more unit test --------- Co-authored-by: Kevin Lind <40409666+kevinlind@users.noreply.github.com> * Update documentation for Datastream Override Feature (#399) * Update documentation for datastream override feature * Added objective c sample and made changes based on reviews * Formatting fixes * Updates based on reviews * Datastream Id Override and Datastream Config Override Implementation (#398) * Implemented Datastream Id override and Datastream config override feature. Refactored processHit function for readability and swift lint warnings. * Added unit tests for the override feature * Add Functional tests * formatting fix * Refactored code based on reviews * Updates based on reviews * More review updates * Test update * Updates based on reviews * Update Codecov configuration * Added upstream integration tests for configOverrides feature (#413) * Added upstream integration tests for configOverrides feature * Updates based on reviews * Assert errors * format fixes * Moved ConfigOverrides test in a separate file. Moved helpers to TestBase and TestHelpers. Refactored some helper code to make it extensible and reusable. * Move edge helpers to a separate extension of TestBase * Updates based on reviews * Updates based on reviews * More updates based on reviews * Skipping tests till Konductor issue PDCL-11131 is fixed --------- Co-authored-by: Kevin Lind <40409666+kevinlind@users.noreply.github.com> Co-authored-by: Emilia Dobrin <33132425+emdobrin@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Integration tests for configOverrides and Konductor responses.
Sample Integration test run: https://github.com/addb/aepsdk-edge-ios/actions/runs/6357026574/job/17267558942
Failing Tests: (Expecting 400 from Konductor, but for some reason getting 200)
Enable above tests after PDCL-11131 issue is fixed:
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: