Skip to content

Update Experience Event class for Datastream Config Override Feature#397

Merged
addb merged 6 commits intoadobe:feature/datastreamConfigOverridefrom
addb:configOverride
Sep 13, 2023
Merged

Update Experience Event class for Datastream Config Override Feature#397
addb merged 6 commits intoadobe:feature/datastreamConfigOverridefrom
addb:configOverride

Conversation

@addb
Copy link
Copy Markdown
Contributor

@addb addb commented Sep 7, 2023 •
edited
Loading

Description

Add datastream config override using sendEvent API:

let expEventWithConfigOverride = ExperienceEvent(xdm: ["test": "value"], datastreamIdOverride: "DATA_STREAM_ID", datastreamConfigOverride: ["testConfig": "testValue"])

Edge.sendEvent(experienceEvent: expEventWithConfigOverride)

Event Payload:

[AEP SDK TRACE - <EventHub>] Dispatching Event #Optional(15) -     [
      id: 8856BF19-E3A0-4581-A27F-3F4A848DA874
      name: AEP Request Event
      type: com.adobe.eventType.edge
      source: com.adobe.eventSource.requestContent
      data: {
  "xdm" : {
    "test" : "value"
  },
  "config" : {
    "datastreamIdOverride" : "DATA_STREAM_ID",
    "datastreamConfigOverride" : {
      "testConfig" : "testValue"
    }
  }
}

Changes:

  • Modified Experience Event constructor and added convenience constructors for optional fields.
  • Added new fields for datastreamIdOverride and datastreamConfigOverride
  • Added unit tests for the change

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

kevinlind and others added 2 commits September 1, 2023 17:19
@kevinlind
Merge pull request adobe#395 from adobe/main
c3ce8a6 
Downmerge `main` to `dev` after v4.2.0 release
@addb
Modify Experience event class to add datastreamIdOverride and datastr…
d129db7 
…eamConfigOverride fields.
@addb addb requested review from emdobrin and kevinlind September 7, 2023 22:23
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 7, 2023 •
edited
Loading

Codecov Report

Merging #397 (f10ad76) into feature/datastreamConfigOverride (9aef3e6) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@                         Coverage Diff                          @@
##           feature/datastreamConfigOverride     #397      +/-   ##
====================================================================
+ Coverage                             96.77%   96.82%   +0.05%     
====================================================================
  Files                                    27       27              
  Lines                                  1671     1698      +27     
====================================================================
+ Hits                                   1617     1644      +27     
  Misses                                   54       54

timkimadobe
timkimadobe reviewed Sep 8, 2023
View reviewed changes
emdobrin
emdobrin reviewed Sep 12, 2023
View reviewed changes
emdobrin
emdobrin reviewed Sep 12, 2023
View reviewed changes
@addb addb requested a review from emdobrin September 13, 2023 00:04
emdobrin
emdobrin reviewed Sep 13, 2023
View reviewed changes
emdobrin
emdobrin reviewed Sep 13, 2023
View reviewed changes
@addb addb requested a review from emdobrin September 13, 2023 22:06
@addb addb merged commit 058ac85 into adobe:feature/datastreamConfigOverride Sep 13, 2023
addb added a commit that referenced this pull request Oct 24, 2023
@addb @kevinlind @emdobrin
Feature: Datastream configuration overrides (#426)
5eda28b 
* Update Experience Event class for Datastream Config Override Feature (#397)

* Modify Experience event class to add datastreamIdOverride and datastreamConfigOverride fields.

* Updates based on reviews

* format fixes

* Review updates

* Add more unit test

---------

Co-authored-by: Kevin Lind <40409666+kevinlind@users.noreply.github.com>

* Update documentation for Datastream Override Feature (#399)

* Update documentation for datastream override feature

* Added objective c sample and made changes based on reviews

* Formatting fixes

* Updates based on reviews

* Datastream Id Override and Datastream Config Override Implementation (#398)

* Implemented Datastream Id override and Datastream config override feature. Refactored processHit function for readability and swift lint warnings.

* Added unit tests for the override feature

* Add Functional tests

* formatting fix

* Refactored code based on reviews

* Updates based on reviews

* More review updates

* Test update

* Updates based on reviews

* Update Codecov configuration

* Added upstream integration tests for configOverrides feature (#413)

* Added upstream integration tests for configOverrides feature

* Updates based on reviews

* Assert errors

* format fixes

* Moved ConfigOverrides test in a separate file. Moved helpers to TestBase and TestHelpers. Refactored some helper code to make it extensible and reusable.

* Move edge helpers to a separate extension of TestBase

* Updates based on reviews

* Updates based on reviews

* More updates based on reviews

* Skipping tests till Konductor issue PDCL-11131 is fixed

---------

Co-authored-by: Kevin Lind <40409666+kevinlind@users.noreply.github.com>
Co-authored-by: Emilia Dobrin <33132425+emdobrin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emdobrin emdobrin emdobrin approved these changes

@timkimadobe timkimadobe timkimadobe approved these changes

@kevinlind kevinlind Awaiting requested review from kevinlind

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@addb @emdobrin @timkimadobe @kevinlind