Datastream Id Override and Datastream Config Override Implementation#398
Merged
addb merged 10 commits intoadobe:feature/datastreamConfigOverridefrom Sep 21, 2023
Merged
Conversation
…ture. Refactored processHit function for readability and swift lint warnings.
5 tasks
5 tasks
Codecov Report
@@ Coverage Diff @@
## feature/datastreamConfigOverride #398 +/- ##
====================================================================
- Coverage 96.82% 96.76% -0.06%
====================================================================
Files 27 27
Lines 1698 1729 +31
====================================================================
+ Hits 1644 1673 +29
- Misses 54 56 +2 |
emdobrin
reviewed
Sep 15, 2023
Contributor
emdobrin
left a comment
There was a problem hiding this comment.
Left few comments, will review the tests after these updates
kevinlind
reviewed
Sep 18, 2023
kevinlind
reviewed
Sep 18, 2023
emdobrin
reviewed
Sep 19, 2023
kevinlind
reviewed
Sep 20, 2023
emdobrin
approved these changes
Sep 21, 2023
Contributor
emdobrin
left a comment
There was a problem hiding this comment.
Looks good with Kevin's comments
kevinlind
approved these changes
Sep 21, 2023
Merged
10 tasks
addb
added a commit
that referenced
this pull request
Oct 24, 2023
* Update Experience Event class for Datastream Config Override Feature (#397) * Modify Experience event class to add datastreamIdOverride and datastreamConfigOverride fields. * Updates based on reviews * format fixes * Review updates * Add more unit test --------- Co-authored-by: Kevin Lind <40409666+kevinlind@users.noreply.github.com> * Update documentation for Datastream Override Feature (#399) * Update documentation for datastream override feature * Added objective c sample and made changes based on reviews * Formatting fixes * Updates based on reviews * Datastream Id Override and Datastream Config Override Implementation (#398) * Implemented Datastream Id override and Datastream config override feature. Refactored processHit function for readability and swift lint warnings. * Added unit tests for the override feature * Add Functional tests * formatting fix * Refactored code based on reviews * Updates based on reviews * More review updates * Test update * Updates based on reviews * Update Codecov configuration * Added upstream integration tests for configOverrides feature (#413) * Added upstream integration tests for configOverrides feature * Updates based on reviews * Assert errors * format fixes * Moved ConfigOverrides test in a separate file. Moved helpers to TestBase and TestHelpers. Refactored some helper code to make it extensible and reusable. * Move edge helpers to a separate extension of TestBase * Updates based on reviews * Updates based on reviews * More updates based on reviews * Skipping tests till Konductor issue PDCL-11131 is fixed --------- Co-authored-by: Kevin Lind <40409666+kevinlind@users.noreply.github.com> Co-authored-by: Emilia Dobrin <33132425+emdobrin@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: