Skip to content

Dev -> Staging (v3.0.4)#65

Merged
addb merged 16 commits intostagingfrom
dev-v3.0.4
Mar 30, 2022
Merged

Dev -> Staging (v3.0.4)#65
addb merged 16 commits intostagingfrom
dev-v3.0.4

Conversation

@addb
Copy link
Copy Markdown
Collaborator

@addb addb commented Mar 30, 2022

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

addb and others added 16 commits October 25, 2021 16:52
staging -> main (v3.0.3)
Update build scripts and add debug symbols to fix the build archive step
* Remove SwiftFormat from project.
As SwiftFormat is not automatically installed like SwiftLint is, customers can get build failures.

* Add required 'getHistoricalEvents' method to TestableExtensionRuntime

* Remove leading whitespace from run script.

* Update CircleCI Xcode image to 12.0.1

* Remove SwiftFormat
Downmerge main to dev after script updates
* Coverage fix

* Reset cocoapods cache

* Enable coverage collection

* Update targets to ios 10

* Set a simulator that exists

* Remove overwritten settings, podfile update

* Conform to TestableExtension

* Revert simulator change

* Fixes after merge conflicts
…eturn nil string and not return unexpected error when aid vid values are not found. (#62)

* [MOB-15980] Fixed getTrackingIdentifier and getVisitorIdentifier to return nil string and not return unexpected error when aid vid values are not found.

* [MOB-15980] Update Xcode version to 12.0.1 in Circle CI config, since 11.2.1 Xcode is no longer supported by Circle CI.

* [MOB-15980] Fix unit tests

* [MOB-15980] Return unexpected error when identifer values are not a valid string

* [MOB-15980] Simplify logic
Bump up version for v3.0.4 release
@addb addb requested review from cacheung, emdobrin and kevinlind March 30, 2022 00:17
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2022

Codecov Report

Merging #65 (59bf6f9) into staging (81f91a0) will increase coverage by 0.28%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           staging      #65      +/-   ##
===========================================
+ Coverage    89.93%   90.21%   +0.28%     
===========================================
  Files           13       14       +1     
  Lines         1082     1113      +31     
===========================================
+ Hits           973     1004      +31     
  Misses         109      109              

@addb addb merged commit ca349ce into staging Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants