Update build scripts and add debug symbols to fix the build archive step#57
Update build scripts and add debug symbols to fix the build archive step#57emdobrin merged 7 commits intoadobe:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## dev-v3.0.4 #57 +/- ##
==============================================
- Coverage 91.20% 89.93% -1.27%
==============================================
Files 13 13
Lines 1170 1082 -88
==============================================
- Hits 1067 973 -94
- Misses 103 109 +6 |
cdhoffmann
left a comment
There was a problem hiding this comment.
Thank you for working on this. The only comment i have is about the changes in the readme. I think it could be worded a little better. Something like:
"First run make pod-install to ensure dependencies are installed. Then run make archive from the root directory to generate .xcframeworks for each module under the build folder. Drag and drop all .xcframeworks to your app target in Xcode.
|
@cdhoffmann the archive command also runs pod update https://github.com/adobe/aepsdk-analytics-ios/pull/57/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52R33 so I think this additional comment is not necessary |
|
@emdobrin Good call. We can probably just leave the readme as it was before this PR then. |
|
|
||
| format: | ||
| swiftformat . --swiftversion 5.2 | ||
| swiftformat . --swiftversion 5.1 |
There was a problem hiding this comment.
do we need to specify the version L42 and L52?
There was a problem hiding this comment.
Yes we need the version
warning: No Swift version was specified, so some formatting features were disabled. Specify the version of Swift you are using with the --swiftversion option, or by adding a .swift-version file to your project.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: