Fix run script to remove SwiftFormat#59
Merged
kevinlind merged 5 commits intoadobe:mainfrom Feb 15, 2022
Merged
Conversation
As SwiftFormat is not automatically installed like SwiftLint is, customers can get build failures.
emdobrin
reviewed
Feb 15, 2022
Contributor
emdobrin
left a comment
There was a problem hiding this comment.
Looks like we still use swiftformat in makefile and ci, do we want to continue using them that way?
Contributor
Author
I'm okay with removing SwiftFormat. We have SwiftLint and it provides good integration options for us so I don't see the need for SwiftFormat as well. |
emdobrin
approved these changes
Feb 15, 2022
Codecov Report
@@ Coverage Diff @@
## main #59 +/- ##
===========================================
- Coverage 89.93% 55.92% -34.01%
===========================================
Files 13 14 +1
Lines 1082 1107 +25
===========================================
- Hits 973 619 -354
- Misses 109 488 +379 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update project build run script to use SwiftLint from Pods directory and remove SwiftFormat. As SwiftFormat is not automatically installed, like SwiftLint from CocoaPods, customers are reporting build failures when making the Analytics XCFramework.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: