Codecov Report

Merging #62 (1167d19) into dev-v3.0.4 (1a14741) will increase coverage by 34.29%.
The diff coverage is 100.00%.

@@               Coverage Diff               @@
##           dev-v3.0.4      #62       +/-   ##
===============================================
+ Coverage       55.92%   90.21%   +34.29%     
===============================================
  Files              14       14               
  Lines            1107     1113        +6     
===============================================
+ Hits              619     1004      +385     
+ Misses            488      109      -379     

I am considering an alternative solution, to modify getSharedState to include empty values when aid/vid are not available, so the shared state and response identity event shares the keys verbosely like:

Standard shared state created for com.adobe.module.analytics with version x and data: 
{
  "aid" : "",
  "vid" : ""
}

This option is also in line with Android and ACP versions. @kevinlind @addb thoughts?

I am considering an alternative solution, to modify getSharedState to include empty values when aid/vid are not available, so the shared state and response identity event shares the keys verbosely like:

Standard shared state created for com.adobe.module.analytics with version x and data: 
{
  "aid" : "",
  "vid" : ""
}

This option is also in line with Android and ACP versions. @kevinlind @addb thoughts?

Honestly, I prefer to filter out null/empty values from the EventData. I think the Swift implementation actually corrects the C++ implementation, so I'd like to leave the shared state as it is.
If anything, I would suggest, in IdentityProperties, to set aid/vid to nil if the setter's are passed an empty string. It appears the current implementation could return either nil or empty string to the public API.

I am considering an alternative solution, to modify getSharedState to include empty values when aid/vid are not available, so the shared state and response identity event shares the keys verbosely like:

Standard shared state created for com.adobe.module.analytics with version x and data: 
{
  "aid" : "",
  "vid" : ""
}

This option is also in line with Android and ACP versions. @kevinlind @addb thoughts?

Honestly, I prefer to filter out null/empty values from the EventData. I think the Swift implementation actually corrects the C++ implementation, so I'd like to leave the shared state as it is. If anything, I would suggest, in IdentityProperties, to set aid/vid to nil if the setter's are passed an empty string. It appears the current implementation could return either nil or empty string to the public API.

I am also of the opinion to not share empty values and instead have nil.

Sounds good, let's make sure the shared state/response event docs are up to date too.
Left some small comments on the logic.