feat: add execute method to commands#17
Closed
lukealvoeiro wants to merge 14 commits intomainfrom
Closed
Conversation
.execute(...) command.execute(...) method for commands
42291be to
4d65ce1
Compare
* main: fix: typo in exchange method `rewind` (#54) fix: remove unsafe pop of messages (#47) chore: Update LICENSE (#53) chore(docs): update is_dangerous_command method description (#48) refactor: improve safety rails speed and prompt (#45) feat: make goosehints jinja templated (#43) ci: enforce PR title follows conventional commit (#14) feat: show available toolkits (#37) adding in ability to provide per repo hints (#32) Apply ruff and add to CI (#40) added some regex based checks for dangerous commands (#38) chore: Update publish github workflow to check package versions before publishing (#19) chore: upgrade ai-exchange dependency (#36) fix: resuming sessions (#35) feat: upgrade `ai-exchange` to version `0.8.3` and fix tests (#34) fix: export metadata.plugins export should have valid module (#30) fix (#24) link to vs code extension (#20) Enable cli options for plugin (#22) Modified the readme to be more friendly to new users (#16)
bf39f0d to
c26a5c9
Compare
.execute(...) method for commands|
|
||
|
|
||
| def create_prompt() -> PromptSession: | ||
| def create_prompt(commands: dict[str, Command]) -> PromptSession: |
Contributor
There was a problem hiding this comment.
I know this is an old function but can we get a docstring since it's part of your PR 🙏
Contributor
Author
There was a problem hiding this comment.
for sure, good call!
| @staticmethod | ||
| def create_prompt_session() -> "GoosePromptSession": | ||
| return GoosePromptSession(create_prompt()) | ||
| def get_message_after_commands(self, message: str) -> str: |
Contributor
There was a problem hiding this comment.
I added some comments to make the flow of logic clearer to the uninitiated but feel free to ignore!
Collaborator
|
I am curious whether there is any real use case to use the command It would be good to have a clear purpose while we adding code as code maintenance could be a cost. |
Contributor
Author
|
@lifeizhou-ap we have the quorum toolkit which will be using this, as well as the file command. given this, that's why the ticket has a high priority on our internal Linear board. it's also a bit of a catch-22, where if we don't give engineers the ability to run commands, we won't see additional use-cases for it. |
Contributor
|
Sorry for automated comments on this pull request. Goose used the current directory instead of the plugins repo to send these comments. |
26 tasks
jamadeo
pushed a commit
that referenced
this pull request
Apr 13, 2026
* fix: repair broken settings modal layout The <nav> element with settings navigation buttons was a sibling of the sidebar div instead of being nested inside it, and the main flex container was missing its closing tag. This broke the sidebar/content flex layout. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: restore missing padding wrapper around Settings title The merge in #15 dropped a wrapper div with px-4 py-4 padding and entrance animation around the "Settings" heading, causing it to be smashed against the top-left corner of the sidebar. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * refactor: consolidate types and stores into feature-sliced architecture Removed root-level src/types/ and src/stores/ directories that contained outdated duplicates of types and unused store implementations. Moved unique config types (AgentConfig, Skill, Provider, Model) to src/shared/types/config.ts. Relocated stores to their owning features (agentConfigStore → agents, sessionStore → chat, skillStore → skills). Deduplicated ChatState, TokenState, and Session types — src/shared/types/chat.ts is now canonical. Updated AGENTS.md with clear guidelines on where types and stores should live. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About
Before this PR, commands would lexed in the following way:
After this PR, commands are lexed as so: