Skip to content

fix: resuming sessions#35

Merged
lukealvoeiro merged 4 commits intomainfrom
lalvoeiro/fix-resuming-sessions
Sep 3, 2024
Merged

fix: resuming sessions#35
lukealvoeiro merged 4 commits intomainfrom
lalvoeiro/fix-resuming-sessions

Conversation

@lukealvoeiro
Copy link
Copy Markdown
Contributor

@lukealvoeiro lukealvoeiro commented Sep 3, 2024

Before this PR, when a session was resumed there were a few edge cases where we would fail to resume correctly. This PR fixes all of them to ensure we always can resume the session safely, while minimizing the context lost.

@lukealvoeiro lukealvoeiro changed the title fix: resuming test cases fix: resuming sessions Sep 3, 2024
* main:
  feat: upgrade `ai-exchange` to version `0.8.3` and fix tests (#34)
@lukealvoeiro lukealvoeiro merged commit fadeba9 into main Sep 3, 2024
lukealvoeiro added a commit that referenced this pull request Sep 4, 2024
…l-commit-title-pr

* origin/main:
  feat: show available toolkits (#37)
  adding in ability to provide per repo hints (#32)
  Apply ruff and add to CI (#40)
  added some regex based checks for dangerous commands (#38)
  chore: Update publish github workflow to check package versions before publishing (#19)
  chore: upgrade ai-exchange dependency (#36)
  fix: resuming sessions (#35)
  feat: upgrade `ai-exchange` to version `0.8.3` and fix tests (#34)
  fix: export metadata.plugins export should have valid module (#30)
  fix (#24)
  link to vs code extension (#20)
  Enable cli options for plugin (#22)
  Modified the readme to be more friendly to new users (#16)
  chore: gitignore generated lockfile (#15)
  add prompts (#11)
  conditionally publish only when config changes (#9)
lukealvoeiro pushed a commit that referenced this pull request Sep 9, 2024
lukealvoeiro added a commit that referenced this pull request Sep 9, 2024
* main:
  fix: typo in exchange method `rewind` (#54)
  fix: remove unsafe pop of messages (#47)
  chore: Update LICENSE (#53)
  chore(docs): update is_dangerous_command method description (#48)
  refactor: improve safety rails speed and prompt (#45)
  feat: make goosehints jinja templated (#43)
  ci: enforce PR title follows conventional commit (#14)
  feat: show available toolkits (#37)
  adding in ability to provide per repo hints (#32)
  Apply ruff and add to CI (#40)
  added some regex based checks for dangerous commands (#38)
  chore: Update publish github workflow to check package versions before publishing (#19)
  chore: upgrade ai-exchange dependency (#36)
  fix: resuming sessions (#35)
  feat: upgrade `ai-exchange` to version `0.8.3` and fix tests (#34)
  fix: export metadata.plugins export should have valid module (#30)
  fix (#24)
  link to vs code extension (#20)
  Enable cli options for plugin (#22)
  Modified the readme to be more friendly to new users (#16)
lilydelalande pushed a commit that referenced this pull request Oct 7, 2024
@lamchau lamchau deleted the lalvoeiro/fix-resuming-sessions branch October 24, 2024 11:46
ahau-square pushed a commit that referenced this pull request May 2, 2025
cbruyndoncx pushed a commit to cbruyndoncx/goose that referenced this pull request Jul 20, 2025
jamadeo pushed a commit that referenced this pull request Apr 13, 2026
…#35)

* fix: resume existing ACP sessions instead of always creating new ones

Each message was spawning a fresh ACP session because send_prompt always
passed None as the agent_session_id. The TauriStore already persisted
the agent-to-session mapping via set_agent_session_id, but never read it
back. Added get_agent_session_id to TauriStore and wired it into
send_prompt so subsequent messages in a chat resume the existing session.

Also excludes .agents/ from biome checks to fix pre-existing hook failure
on markdown skill files.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: address code review comments on ACP session resumption

Use a typed Deserialize struct instead of serde_json::Value for
get_agent_session_id to catch schema drift at compile time, and fix
missing space after // in section divider comments.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* style: fix Rust formatting and simplify get_agent_session_id

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: remove unused Deserialize import in acp.rs

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* style: restore section divider comments in acp.rs

The previous formatting commits inadvertently stripped the
`// ---------------------------------------------------------------------------`
section dividers. Restore them for all five sections and add a narrow
file-size exception (550 lines) since the dividers push the file just
past the 500-line default.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants